Added additional metrics to peer forwarder#1836
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom Sep 30, 2022
Merged
Added additional metrics to peer forwarder#1836dlvenable merged 1 commit intoopensearch-project:mainfrom
dlvenable merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Asif Sohail Mohammed <nsifmoh@amazon.com>
dlvenable
approved these changes
Sep 29, 2022
| verify(recordsActuallyProcessedLocallyCounter).increment(1.0); | ||
| verify(recordsToBeForwardedCounter).increment(1.0); | ||
| verify(requestsSuccessfulCounter).increment(); | ||
| verify(recordsSuccessfullyForwardedCounter).increment(1.0); |
Member
There was a problem hiding this comment.
It could be good to verify this with a value greater than 1 as well.
oeyh
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asif Sohail Mohammed nsifmoh@amazon.com
Description
Added
recordsSuccessfullyForwardedandrequestsSuccessfulmetricsIssues Resolved
resolves #1609
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.