[GRPC] Update gRPC usage instructions and fix java examples#11199
[GRPC] Update gRPC usage instructions and fix java examples#11199natebower merged 6 commits intoopensearch-project:mainfrom
Conversation
… to 0.19.0 protos Signed-off-by: Karen X <karenxyr@gmail.com>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
karenyrx
requested review from
AMoo-Miki,
dlvenable,
epugh,
kolchfa-aws,
natebower and
sumobrian
as code owners
Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: Karen X <karenxyr@gmail.com>
|
I think there were a couple minor name changes in bulk request: OperationContainer added to BulkBody: -> |
_api-reference/grpc-apis/search.md
Outdated
|
|
||
| HitsMetadata hits = response.getHits(); | ||
| if (hits.hasTotal()) { | ||
| System.out.println("Total hits: " + hits.getTotal().getValue()); |
There was a problem hiding this comment.
System.out.println("Total hits: " + hits.getTotal().getTotalHits().getValue());
|
Added couple comments on variable name changes - otherwise LGTM. |
|
hi @kolchfa-aws could you help review this? Tech review is complete. Thanks! |
kolchfa-aws
left a comment
kolchfa-aws
left a comment
There was a problem hiding this comment.
Thank you, @karenyrx! Please see my comments and let me know if you have any questions.
kolchfa-aws
added
Doc review
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Nathan Bower <nbower@amazon.com>
natebower
left a comment
natebower
left a comment
There was a problem hiding this comment.
Doc and editorial reviews complete. LGTM
…ch-project#11199) * [GRPC] Update gRPC usage instructions and fix java examples to adhere to 0.19.0 protos Signed-off-by: Karen X <karenxyr@gmail.com> * fix links Signed-off-by: Karen X <karenxyr@gmail.com> * update bulk Signed-off-by: Karen X <karenxyr@gmail.com> * update Signed-off-by: Karen X <karenxyr@gmail.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Nathan Bower <nbower@amazon.com> --------- Signed-off-by: Karen X <karenxyr@gmail.com> Signed-off-by: Nathan Bower <nbower@amazon.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: etgraylog <evan.tepsic@graylog.com>
4 participants
Description
Issues Resolved
Closes #10999
Version
3.3+
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.