Setting-envars-docs #3582#7400
Merged
Naarcha-AWS merged 4 commits intoopensearch-project:mainfrom Jul 9, 2024
Merged
Conversation
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
AntonEliatra
requested review from
AMoo-Miki,
Naarcha-AWS,
dlvenable,
epugh,
hdhalter,
kolchfa-aws,
natebower,
stephen-crawford and
vagimeli
as code owners
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
stephen-crawford
approved these changes
Jun 24, 2024
hdhalter
added
Doc review
Naarcha-AWS
suggested changes
Jul 3, 2024
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Naarcha-AWS
approved these changes
Jul 5, 2024
Naarcha-AWS
added
5 - Final Editorial Review
and removed
Doc review
natebower
reviewed
Jul 9, 2024
Contributor
natebower
left a comment
natebower
left a comment
There was a problem hiding this comment.
@Naarcha-AWS @AntonEliatra A few comments for you. Thanks!
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Contributor
Author
|
@natebower good catch, thats updated now |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
* setting-envars-docs #3582 Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update index.md Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update index.md Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> --------- Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> (cherry picked from commit 8f6ea3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 tasks
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-documentation-website-forl
that referenced
this pull request
Jul 24, 2024
* setting-envars-docs opensearch-project#3582 Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update index.md Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update index.md Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> --------- Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
sandervandegeijn
pushed a commit
to sandervandegeijn/documentation-website
that referenced
this pull request
Jul 30, 2024
* setting-envars-docs opensearch-project#3582 Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update index.md Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update index.md Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> --------- Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sander van de Geijn <sandervandegeijn@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expanding on options to configure envars in OpenSearch
Issues Resolved
Partly closes #3582
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.