Clarify master-to-cluster-manager name change#8784
Merged
kolchfa-aws merged 1 commit intoopensearch-project:mainfrom Nov 20, 2024
Merged
Clarify master-to-cluster-manager name change#8784kolchfa-aws merged 1 commit intoopensearch-project:mainfrom
kolchfa-aws merged 1 commit intoopensearch-project:mainfrom
Conversation
In opensearch-project#7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com>
bwolak
requested review from
AMoo-Miki,
Naarcha-AWS,
dlvenable,
epugh,
kolchfa-aws,
natebower and
vagimeli
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
approved these changes
Nov 20, 2024
Collaborator
kolchfa-aws
left a comment
kolchfa-aws
left a comment
There was a problem hiding this comment.
Good catch! Thank you, @bwolak!
kolchfa-aws
added
backport 2.15
backport 2.16
backport 2.17
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> (cherry picked from commit 6da9e56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> (cherry picked from commit 6da9e56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> (cherry picked from commit 6da9e56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> (cherry picked from commit 6da9e56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Nov 23, 2024
…-project#8784) In opensearch-project#7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Jul 2, 2025
…-project#8784) In opensearch-project#7660 there was an effort to find-and-replace `master` with `cluster manager`. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes. I also simplified the sentence, as the "nomenclature" part is unnecessary. Signed-off-by: Benjamin Wolak <bwolak@crunchbase.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #7660 there was an effort to find-and-replace
masterwithcluster manager. In this one particular case it was unwarranted however, as the sentence is explaining how master nodes are now called cluster manager nodes.I also simplified the sentence, as the "nomenclature" part is unnecessary.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.