Remove optional to get features#177
Merged
VijayanB merged 1 commit intoopensearch-project:mainfrom Oct 22, 2022
Merged
Conversation
Optional is not required since api returns list instead of object. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
============================================
- Coverage 84.94% 84.55% -0.40%
+ Complexity 333 331 -2
============================================
Files 44 44
Lines 1096 1094 -2
Branches 97 97
============================================
- Hits 931 925 -6
- Misses 126 128 +2
- Partials 39 41 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
martin-gaievski
approved these changes
Oct 22, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 22, 2022
Optional is not required since api returns list instead of object. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 4465452)
VijayanB
pushed a commit
that referenced
this pull request
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optional is not required since api returns
list instead of object.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.