Support Uber's H3 geospatial indexing system as geohex_grid (#179)#180
Merged
Conversation
…ch-project#179) * Import h3 library (opensearch-project#154) Made following changes to make it compatible: 1. Rename package from elasticsearch to opensearch.geospatial 2. Update License headers 3. Update build file 4. Update settings to include sub projects * Use Transport Request (opensearch-project#164) Remove usage of deprecated BaseNodeRequest * Update http client package to resolve build failure (opensearch-project#168) (opensearch-project#171) * Introduce H3 min resolution constant (opensearch-project#165) H3 version 1 has 16 resolutions, numbered 0 through 15. Introduced a constant to represent min value, similar to max value. * Add geohex aggregation (opensearch-project#160) This aggregation will use uber's h3 to group coordinates into H3 cell. Created new aggregation type geohex_grid. The precision will be between 0 and 15. This aggreation has default precision as 5, similar to geohash and geotile. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Add integration test (opensearch-project#176) Included integration test for geohex_grid. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #180 +/- ##
============================================
+ Coverage 84.73% 84.99% +0.25%
- Complexity 332 376 +44
============================================
Files 44 52 +8
Lines 1094 1186 +92
Branches 97 98 +1
============================================
+ Hits 927 1008 +81
- Misses 128 137 +9
- Partials 39 41 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martin-gaievski
approved these changes
Oct 26, 2022
Member
|
We probably need 2.4 label for this PR |
junqiu-lei
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is back port of #179 . However, in 3.x, Aggregation base class like InternalGeoXxxx were refactored. Hence, we have to use old class as base class for 2.x branch.
Issues Resolved
#98
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.