[Backport 2.x] Fix compilation error and test failure#228
Merged
Conversation
Build failure due to upstream refactoring. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit b63c063)
junqiu-lei
approved these changes
Jul 6, 2023
heemin32
requested review from
VijayanB,
heemin32,
jmazanec15,
martin-gaievski,
naveentatikonda,
navneet1v and
vamshin
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #228 +/- ##
============================================
+ Coverage 84.98% 85.25% +0.27%
+ Complexity 376 356 -20
============================================
Files 52 52
Lines 1172 1160 -12
Branches 97 98 +1
============================================
- Hits 996 989 -7
+ Misses 135 133 -2
+ Partials 41 38 -3
|
heemin32
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport b63c063 from #210