Refactor XContentFactory to MediaTypeRegistry#374
Merged
Conversation
heemin32
requested review from
VijayanB,
jmazanec15,
junqiu-lei,
martin-gaievski,
naveentatikonda,
navneet1v and
vamshin
as code owners
Signed-off-by: Heemin Kim <heemin@amazon.com>
junqiu-lei
approved these changes
Jul 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
============================================
- Coverage 88.65% 88.58% -0.08%
Complexity 752 752
============================================
Files 92 92
Lines 2707 2707
Branches 219 219
============================================
- Hits 2400 2398 -2
- Misses 228 230 +2
Partials 79 79 |
jmazanec15
approved these changes
Jul 28, 2023
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 26b1938)
heemin32
added a commit
to heemin32/geospatial
that referenced
this pull request
Aug 17, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32
added a commit
that referenced
this pull request
Aug 17, 2023
) * Switch from XContentType to MediaType to fix compilation errors (#366) Signed-off-by: Heemin Kim <heemin@amazon.com> * Refactor XContentFactory to MediaTypeRegistry (#374) Signed-off-by: Heemin Kim <heemin@amazon.com> * Refactor LifecycleComponent package path (#377) Signed-off-by: Heemin Kim <heemin@amazon.com> * [Refactor] Strings utility methods to core library (#379) Signed-off-by: Heemin Kim <heemin@amazon.com> * Fixed compilation errors after refactoring in core foundation classes (#380) Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Heemin Kim <heemin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor XContentFactory to MediaTypeRegistry
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.