Add denylist ip config for datasource endpoint#573
Merged
heemin32 merged 1 commit intoopensearch-project:mainfrom Oct 27, 2023
Merged
Add denylist ip config for datasource endpoint#573heemin32 merged 1 commit intoopensearch-project:mainfrom
heemin32 merged 1 commit intoopensearch-project:mainfrom
Conversation
3ec949f to
a2b5c47
Compare
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
============================================
+ Coverage 88.59% 89.03% +0.44%
- Complexity 753 767 +14
============================================
Files 92 93 +1
Lines 2717 2746 +29
Branches 221 223 +2
============================================
+ Hits 2407 2445 +38
+ Misses 230 221 -9
Partials 80 80
|
85ecc6e to
f5a7664
Compare
Collaborator
|
@heemin32 what is the value of the denylist urls? Not able to find anything in this PR? |
navneet1v
reviewed
Oct 27, 2023
Collaborator
Author
For example, in cloud provider, they can maintain denylist so that customer cannot make request to internal services with escalated privilege because cluster is running in service account but not customer account. |
navneet1v
reviewed
Oct 27, 2023
src/main/java/org/opensearch/geospatial/ip2geo/common/URLDenyListChecker.java
Outdated
Show resolved
Hide resolved
navneet1v
reviewed
Oct 27, 2023
src/main/java/org/opensearch/geospatial/ip2geo/action/RestPutDatasourceHandler.java
Show resolved
Hide resolved
d81aa65 to
4a108ec
Compare
naveentatikonda
approved these changes
Oct 27, 2023
Member
|
@heemin32 Build is failing with the latest changes. Pls fix it |
navneet1v
reviewed
Oct 27, 2023
src/main/java/org/opensearch/geospatial/ip2geo/common/URLDenyListChecker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Heemin Kim <heemin@amazon.com>
vibrantvarun
approved these changes
Oct 27, 2023
Member
|
Just reviewed the PR to understand the use-case. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 35edec1)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 35edec1)
heemin32
added a commit
that referenced
this pull request
Oct 27, 2023
heemin32
added a commit
that referenced
this pull request
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a denylist ip config for datasource endpoint so that admin can block certain ip addresses from being used in datasource endpoint
This PR mimicked opensearch-project/sql#2042
When IP address is in the deny list, following message will be returned.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.