Fix: Github CI build fix#701
Merged
heemin32 merged 6 commits intoopensearch-project:mainfrom Dec 6, 2024
Merged
Conversation
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
andy-k-improving
requested review from
VijayanB,
heemin32,
jmazanec15,
junqiu-lei,
martin-gaievski,
naveentatikonda,
navneet1v and
vamshin
as code owners
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
andy-k-improving
changed the title
Contributor
Author
|
https://github.com/Bit-Quill/geospatial/actions/runs/12091483215 |
Collaborator
|
Please add change log under maintenance. |
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
Contributor
Author
|
@heemin32 done, can you trigger the build again? |
navneet1v
reviewed
Nov 30, 2024
Signed-off-by: Andy Kwok <andy.kwok@improving.com>
heemin32
approved these changes
Dec 6, 2024
martin-gaievski
approved these changes
Dec 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Apply fix for node version mismathc Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Apply docker start cmd Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Revert windows and mac Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Update jvm distribution Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Update changelog Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Update changelog Signed-off-by: Andy Kwok <andy.kwok@improving.com> --------- Signed-off-by: Andy Kwok <andy.kwok@improving.com> (cherry picked from commit 35e3106)
heemin32
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Apply fix for node version mismathc Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Apply docker start cmd Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Revert windows and mac Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Update jvm distribution Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Update changelog Signed-off-by: Andy Kwok <andy.kwok@improving.com> * Update changelog Signed-off-by: Andy Kwok <andy.kwok@improving.com> --------- Signed-off-by: Andy Kwok <andy.kwok@improving.com> (cherry picked from commit 35e3106) Co-authored-by: Andy Kwok <andy.kwok@improving.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To introduce additional start command for all CI build which rely on the OpnSearch Docker image, as Github rollout the deprecation of the Node 16 on all it's CI-runner, as the result all existing Github which rely on the old version of Node.JS (Ex: actions/checkout@v3) failed due to the following errors:
The issue has been discovered over opensearch-project/opensearch-build#5178 and fix has been verified and applied on multiple OpenSearch plugin, such as:
Related Issues
Resolves opensearch-project/opensearch-build#5178
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.