persist licenses and developer fields in pom file#732
Merged
heemin32 merged 1 commit intoopensearch-project:mainfrom Mar 24, 2025
will-hwang:publish_fields_in_pom
Merged
persist licenses and developer fields in pom file#732heemin32 merged 1 commit intoopensearch-project:mainfrom will-hwang:publish_fields_in_pom
heemin32 merged 1 commit intoopensearch-project:mainfrom
will-hwang:publish_fields_in_pom
Conversation
will-hwang
requested review from
VijayanB,
heemin32,
jmazanec15,
junqiu-lei,
martin-gaievski,
naveentatikonda,
navneet1v and
vamshin
as code owners
| } | ||
| } | ||
| publications { | ||
| pluginZip(MavenPublication) { publication -> |
Member
There was a problem hiding this comment.
You are changing the behavior of publishing plugin zips.
We should publish both jars and the plugin zips.
Member
There was a problem hiding this comment.
Therefore this is incorrect as you can see it is publishing to org.opensearch.plugin which is reserved for plugin zip. For jars it should go to org.opensearch.
See job schedule example I sent for more reference. Thanks.
Contributor
Author
There was a problem hiding this comment.
will revert and follow the example in job schedule plugin. thanks
build.gradle
Outdated
| dependencyLicenses.enabled = false | ||
| thirdPartyAudit.enabled = false | ||
| loggerUsageCheck.enabled = false | ||
| validateMavenPom.enabled = false |
Member
There was a problem hiding this comment.
This line is already on 48.
.github/workflows/maven-publish.yml
Outdated
Comment on lines
+43
to
+49
| - name: publish pom to maven | ||
| run: | | ||
| export SONATYPE_USERNAME=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-username --query SecretString --output text) | ||
| export SONATYPE_PASSWORD=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-password --query SecretString --output text) | ||
| echo "::add-mask::$SONATYPE_USERNAME" | ||
| echo "::add-mask::$SONATYPE_PASSWORD" | ||
| ./gradlew :geospatial-client:publishMavenPublicationToSnapshotsRepository |
Member
There was a problem hiding this comment.
Why do we need to run a second task for pom?
Should be able to combine with the original.
scripts/build.sh
Outdated
Comment on lines
+89
to
+93
|
|
||
| # Publish pom to maven | ||
| ./gradlew publishToMavenLocal -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT -Dbuild.version_qualifier=$QUALIFIER | ||
| ./gradlew publishMavenPublicationToStagingRepository -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT -Dbuild.version_qualifier=$QUALIFIER | ||
|
|
Signed-off-by: will-hwang <sang7239@gmail.com>
66 tasks
heemin32
approved these changes
Mar 24, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
change plugIn clause to all clause to include information in pom files in both
org.opensearch.opensearch-geospatialandorg.opensearch.geospatial-clientappend fields as xmlNode as in job-schedule to persist when publshing to maven
reference: https://github.com/opensearch-project/job-scheduler/blob/main/build.gradle
Verification
verified
<licenses>and<developers>tag are properly appended to .pom files in following files:~/.m2/repository/org/opensearch/opensearch-geospatial/3.0.0.0-alpha1-SNAPSHOT/opensearch-geospatial-3.0.0.0-alpha1-SNAPSHOT.pom~/.m2/repository/org/opensearch/geospatial-client/3.0.0.0-alpha1-SNAPSHOT/geospatial-client-3.0.0.0-alpha1-SNAPSHOT.pom~/.m2/repository/org/opensearch/plugin/geospatial/3.0.0.0-alpha1-SNAPSHOT/geospatial-3.0.0.0-alpha1-SNAPSHOT.pom~/.m2/repository/org/opensearch/plugin/opensearch-geospatial/3.0.0.0-alpha1-SNAPSHOT/opensearch-geospatial-3.0.0.0-alpha1-SNAPSHOT.pomRelated Issues
Resolves #731
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.