Refresh the Ip2Geo cache and retry one more time when we run into an issue#766
Merged
heemin32 merged 1 commit intoopensearch-project:mainfrom Jun 20, 2025
Merged
Refresh the Ip2Geo cache and retry one more time when we run into an issue#766heemin32 merged 1 commit intoopensearch-project:mainfrom
heemin32 merged 1 commit intoopensearch-project:mainfrom
Conversation
ff30169 to
c786342
Compare
Collaborator
|
I think we should just add retry in these four methods instead of handling each case outside of these methods. Otherwise, there will be case which we are missing to handle and also hard to maintain for future change. |
heemin32
reviewed
Jun 20, 2025
src/main/java/org/opensearch/geospatial/ip2geo/dao/DatasourceDao.java
Outdated
Show resolved
Hide resolved
heemin32
reviewed
Jun 20, 2025
d0a2157 to
bfff4d3
Compare
heemin32
reviewed
Jun 20, 2025
junqiu-lei
approved these changes
Jun 20, 2025
…issue. Signed-off-by: Bo Zhang <bzhangam@amazon.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refresh the Ip2Geo cache and retry one more time when we run into an issue.
After we update the datasouce in the primary shard if we fail to send the request to the nodes with replica shard we will not update the cache. Even later the replica is recovered from the primary shard the cache update logic will not be triggered. So and this change to refresh the cache and retry when we run into an issue.
Related Issues
N/A
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.