Upgrade gradle to 8.4#1289
Merged
jmazanec15 merged 8 commits intoopensearch-project:mainfrom Nov 6, 2023
Merged
Conversation
jmazanec15
requested review from
VijayanB,
heemin32,
junqiu-lei,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan and
vamshin
as code owners
Upgrade gradle to 8.4 to support JDK-21. Refer to https://docs.gradle.org/current/userguide/compatibility.html Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
force-pushed
the
gradle-8.4
branch
from
c4f70f9 to
9b576e9
Compare
jmazanec15
added
the
Infrastructure
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1289 +/- ##
============================================
- Coverage 85.07% 85.01% -0.07%
+ Complexity 1210 1207 -3
============================================
Files 160 160
Lines 4930 4930
Branches 449 449
============================================
- Hits 4194 4191 -3
- Misses 537 543 +6
+ Partials 199 196 -3 |
vibrantvarun
approved these changes
Nov 3, 2023
heemin32
previously approved these changes
Nov 3, 2023
Collaborator
|
@jmazanec15 can we check why windows JDK 11 is breaking, lets not merge the change if GH workflow is breaking. |
Member
Author
|
@navneet1v Right, I thought windows was broken anyway - didnt realize we fixed it. Let me check what happened. |
Simplifies Jacoco logic. From long ago, jacoco support was added through a series of hacks. Some of these hacks are no longer necessary, so they were removed to simplify. Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
force-pushed
the
gradle-8.4
branch
from
3107c29 to
cd128d4
Compare
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
force-pushed
the
gradle-8.4
branch
from
596d69e to
ef9145a
Compare
Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15
force-pushed
the
gradle-8.4
branch
from
ef9145a to
ffa9c72
Compare
Member
Author
|
@navneet1v I fixed the windows issue by simplifying the jacoco logic. There were some outdated hacks in there that no longer apply because the OpenSearch TestTask and IntegTestTask extend the gradle Test class now. |
heemin32
approved these changes
Nov 6, 2023
ryanbogan
approved these changes
Nov 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
Upgrade gradle to 8.4 to support JDK-21. Refer to https://docs.gradle.org/current/userguide/compatibility.html Simplifies Jacoco logic. From long ago, jacoco support was added through a series of hacks. Some of these hacks are no longer necessary, so they were removed to simplify. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit fa57b4b)
95 tasks
jingqimao77-spec
pushed a commit
to jingqimao77-spec/k-NN
that referenced
this pull request
Mar 15, 2026
Upgrade gradle to 8.4 to support JDK-21. Refer to https://docs.gradle.org/current/userguide/compatibility.html Simplifies Jacoco logic. From long ago, jacoco support was added through a series of hacks. Some of these hacks are no longer necessary, so they were removed to simplify. Signed-off-by: John Mazanec <jmazane@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade gradle to 8.4 to support JDK-21. Refer to
https://docs.gradle.org/current/userguide/compatibility.html
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.