Bump JDK to 24, gradle to 8.14 by finnroblin · Pull Request #2792 · opensearch-project/k-NN

finnroblin · 2025-07-14T18:19:21Z

Description

Upgrade Java version to 24 and gradle to 8.14 as per ask from infra team.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

New functionality includes testing.
New functionality has been documented.
API changes companion pull request created.
Commits are signed per the DCO using --signoff.
Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

finnroblin · 2025-07-14T18:45:54Z

Build failures are coming from the :remote-index-build-client:compileJava task.

...
Caused by: java.lang.NoSuchFieldException: com.sun.tools.javac.code.TypeTag :: UNKNOWN
        at lombok.permit.Permit.getField(Permit.java:144)
        at lombok.javac.JavacTreeMaker$SchroedingerType.getFieldCached(JavacTreeMaker.java:171)
        at lombok.javac.JavacTreeMaker$TypeTag.typeTag(JavacTreeMaker.java:259)
        at lombok.javac.Javac.<clinit>(Javac.java:186)

I am investigating if bumping the lombok version will fix this.

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

finnroblin · 2025-07-14T18:55:23Z

Build is working locally, rerunning CI with lombok upgrade.

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

…emorySize deprecation issue Signed-off-by: Finn Roblin <finnrobl@amazon.com>

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

finnroblin · 2025-07-15T00:49:12Z

Ah. seems that we need accessUnixDomainSocket permission for windows, thanks to @expani for the help! (ref here)

finnroblin · 2025-07-15T01:48:19Z

Hi @reta, the k-NN plugin windows CI is failing after JDK 24 bump likely due to security manager deprecation. The cause appears to be an AccessController.doPrivileged action that makes a HTTP request to the remote vector build service.

I added permission java.net.NetPermission "accessUnixDomainSocket" based on your PR in transport plugins. However, that does not fix the CI run. Do you have any suggestions of other security/java agent changes required to onboard to JDK 24? Thanks

reta · 2025-07-15T02:04:32Z

Do you have any suggestions of other security/java agent changes required to onboard to JDK 24? Thanks

Hi @finnroblin , sure, I will take a look shortly, couldn't point to the exact problem yet since we have seen a few. Thank you

cwperks · 2025-07-15T02:21:02Z

@reta I'm about to raise a PR in core. A few min.

cwperks · 2025-07-15T02:22:45Z

@reta Not sure how to test, but I believe the changes in opensearch-project/OpenSearch#18752 would resolve the issue.

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

finnroblin · 2025-07-16T16:26:34Z

Windows CI passing after this change merged into core. Thanks @cwperks @reta!

jmazanec15

LGTM!

naveentatikonda · 2025-07-16T16:47:06Z

src/main/plugin-metadata/plugin-security.policy

    permission java.lang.RuntimePermission "loadLibrary.opensearchknn_faiss_avx512";
    permission java.lang.RuntimePermission "loadLibrary.opensearchknn_faiss_avx512_spr";
    permission java.net.SocketPermission "*", "connect,resolve";
+    permission java.net.NetPermission "accessUnixDomainSocket";


Why are we adding this?

We need this permission for remote index build client on windows. Otherwise it will fail due to the OS security manager. OS core needed to add it to their transport plugins which use similar mechanisms to remote index build client.

makes sense. Thanks!

* Bump JDK to 24, gradle to 8.14 Signed-off-by: Finn Roblin <finnrobl@amazon.com> * bump lombok to 8.14, add changelog entry Signed-off-by: Finn Roblin <finnrobl@amazon.com> * bump jacoco version Signed-off-by: Finn Roblin <finnrobl@amazon.com> * remove java 24 from bwc to avoid getTotalPhysicalMemorySize/getTotalMemorySize deprecation issue Signed-off-by: Finn Roblin <finnrobl@amazon.com> * switch from deprecate java SM to opensearch SM in RemoteIndexHTTPClient Signed-off-by: Finn Roblin <finnrobl@amazon.com> * add accessUnixDomainSocket to fix windows CI Signed-off-by: Finn Roblin <finnrobl@amazon.com> * changelog change to rerun CI Signed-off-by: Finn Roblin <finnrobl@amazon.com> --------- Signed-off-by: Finn Roblin <finnrobl@amazon.com> Signed-off-by: Leo Yu <leonyu@amazon.com>

* Bump JDK to 24, gradle to 8.14 Signed-off-by: Finn Roblin <finnrobl@amazon.com> * bump lombok to 8.14, add changelog entry Signed-off-by: Finn Roblin <finnrobl@amazon.com> * bump jacoco version Signed-off-by: Finn Roblin <finnrobl@amazon.com> * remove java 24 from bwc to avoid getTotalPhysicalMemorySize/getTotalMemorySize deprecation issue Signed-off-by: Finn Roblin <finnrobl@amazon.com> * switch from deprecate java SM to opensearch SM in RemoteIndexHTTPClient Signed-off-by: Finn Roblin <finnrobl@amazon.com> * add accessUnixDomainSocket to fix windows CI Signed-off-by: Finn Roblin <finnrobl@amazon.com> * changelog change to rerun CI Signed-off-by: Finn Roblin <finnrobl@amazon.com> --------- Signed-off-by: Finn Roblin <finnrobl@amazon.com>

Bump JDK to 24, gradle to 8.14

dedbedf

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

bump lombok to 8.14, add changelog entry

2937c7f

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

finnroblin and others added 3 commits July 14, 2025 12:11

bump jacoco version

c480ce5

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

Merge branch 'main' into jdk-24-bump

6113dd5

remove java 24 from bwc to avoid getTotalPhysicalMemorySize/getTotalM…

8104992

…emorySize deprecation issue Signed-off-by: Finn Roblin <finnrobl@amazon.com>

heemin32 mentioned this pull request Jul 14, 2025

Updated gradle and java version to 24 opensearch-project/neural-search#1436

Merged

5 tasks

switch from deprecate java SM to opensearch SM in RemoteIndexHTTPClient

a71d605

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

finnroblin marked this pull request as ready for review July 15, 2025 00:09

finnroblin requested review from 0ctopus13prime, VijayanB, Vikasht34, heemin32, jmazanec15, junqiu-lei, luyuncheng, martin-gaievski, naveentatikonda, navneet1v, ryanbogan, shatejas and vamshin as code owners July 15, 2025 00:09

add accessUnixDomainSocket to fix windows CI

1851c62

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

cwperks mentioned this pull request Jul 15, 2025

Fix issue with socket connection in windows tests due to java agent and jdk24 opensearch-project/OpenSearch#18752

Closed

3 tasks

changelog change to rerun CI

af11361

Signed-off-by: Finn Roblin <finnrobl@amazon.com>

jmazanec15 approved these changes Jul 16, 2025

View reviewed changes

martin-gaievski mentioned this pull request Jul 16, 2025

Upgrade gradle to 8.14 and JDK 23->24 opensearch-project/search-relevance#188

Merged

naveentatikonda approved these changes Jul 16, 2025

View reviewed changes

naveentatikonda reviewed Jul 16, 2025

View reviewed changes

naveentatikonda merged commit 6c9c621 into opensearch-project:main Jul 16, 2025
37 checks passed

tkykenmt mentioned this pull request Jan 10, 2026

[bugfix] Build Infrastructure (Gradle/JDK) tkykenmt/opensearch-feature-explorer#1078

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump JDK to 24, gradle to 8.14#2792

Bump JDK to 24, gradle to 8.14#2792
naveentatikonda merged 8 commits intoopensearch-project:mainfrom
finnroblin:jdk-24-bump

finnroblin commented Jul 14, 2025

Uh oh!

finnroblin commented Jul 14, 2025

Uh oh!

finnroblin commented Jul 14, 2025

Uh oh!

finnroblin commented Jul 15, 2025

Uh oh!

finnroblin commented Jul 15, 2025

Uh oh!

reta commented Jul 15, 2025

Uh oh!

cwperks commented Jul 15, 2025

Uh oh!

cwperks commented Jul 15, 2025

Uh oh!

finnroblin commented Jul 16, 2025

Uh oh!

jmazanec15 left a comment

Uh oh!

naveentatikonda Jul 16, 2025

Uh oh!

finnroblin Jul 16, 2025

Uh oh!

naveentatikonda Jul 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

finnroblin commented Jul 14, 2025

Description

Related Issues

Check List

Uh oh!

finnroblin commented Jul 14, 2025

Uh oh!

finnroblin commented Jul 14, 2025

Uh oh!

finnroblin commented Jul 15, 2025

Uh oh!

finnroblin commented Jul 15, 2025

Uh oh!

reta commented Jul 15, 2025

Uh oh!

cwperks commented Jul 15, 2025

Uh oh!

cwperks commented Jul 15, 2025

Uh oh!

finnroblin commented Jul 16, 2025

Uh oh!

jmazanec15 left a comment

Choose a reason for hiding this comment

Uh oh!

naveentatikonda Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

finnroblin Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

naveentatikonda Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants