Fix guava and errorprone dependencies#2883
Closed
karenyrx wants to merge 8 commits intoopensearch-project:mainfrom
Closed
Fix guava and errorprone dependencies#2883karenyrx wants to merge 8 commits intoopensearch-project:mainfrom
karenyrx wants to merge 8 commits intoopensearch-project:mainfrom
Conversation
karenyrx
changed the title
navneet1v
reviewed
Sep 18, 2025
Signed-off-by: karenx <karenx@uber.com>
Signed-off-by: karenx <karenx@uber.com>
Signed-off-by: karenx <karenx@uber.com>
Contributor
Author
|
starting a local opensearch cluster using continuing to debug if the failing CI is related |
karenyrx
changed the title
Contributor
Author
|
The current failing CI on this PR is due to @bzhangam @navneet1v I believe this fix should resolve the previous CI failure, would you mind helping take a look tomorrow? |
Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: Karen X <karenxyr@gmail.com>
karenyrx
commented
Sep 18, 2025
|
|
||
| apply from : "$rootDir/qa/build.gradle" | ||
|
|
||
| dependencies { |
Contributor
Author
There was a problem hiding this comment.
not needed as it inherits from qa/build.gradle (as it has apply from : "$rootDir/qa/build.gradle" on Line 9)
|
|
||
| apply from : "$rootDir/qa/build.gradle" | ||
|
|
||
| dependencies { |
Contributor
Author
There was a problem hiding this comment.
not needed as it inherits from qa/build.gradle (as it has apply from : "$rootDir/qa/build.gradle" on Line 9)
0ctopus13prime
requested review from
0ctopus13prime,
VijayanB,
Vikasht34,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
ryanbogan,
shatejas and
vamshin
as code owners
Contributor
|
@karenyrx I think in your test your knn query didn't go through. It fail fast due to index not found issue. You probably want to create a knn index and index some docs and then run knn query. And in this PR's BWS failure I also find Which seems the real issue causing the failure. |
Collaborator
|
@karenyrx the runtime issues are still happning Please fix this ASAP. This is blocking multiple features |
Signed-off-by: karenx <karenx@uber.com>
Collaborator
|
@karenyrx still the issue persist, can you please check. |
Signed-off-by: karenx <karenx@uber.com>
Signed-off-by: karenx <karenx@uber.com>
|
Hi @navneet1v @bzhangam @karenyrx , I was thinking this is not related to grpc transport which should not include guava at all since the SPI was introduced. There is this PR on core which I think made it into the snapshot at the time when CI began failing: The dependency insights tool seems to me to indicate this is the cause of failures. |
3 tasks
Contributor
Author
|
Closing this PR, in lieu of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To address this CI failure (
Execution failed for task ':compileTestFixturesJava'.)References:
PR 2817
PR 2833
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.