Move test codecs to test sources#3151
Open
reta wants to merge 4 commits intoopensearch-project:mainfrom
Open
Conversation
Signed-off-by: Andriy Redko <drreta@gmail.com>
reta
requested review from
0ctopus13prime,
VijayanB,
Vikasht34,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan,
shatejas and
vamshin
as code owners
reta
commented
Mar 9, 2026
| org.opensearch.knn.index.codec.backward_codecs.KNN10010Codec.KNN10010Codec | ||
| org.opensearch.knn.index.codec.backward_codecs.KNN1030Codec.KNN1030Codec | ||
| org.opensearch.knn.index.codec.KNN1040Codec.KNN1040Codec | ||
| org.opensearch.knn.index.codec.util.UnitTestCodec |
Contributor
Author
There was a problem hiding this comment.
This is test codec and should be inside test source set
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
============================================
+ Coverage 82.66% 82.73% +0.06%
- Complexity 3977 3979 +2
============================================
Files 433 432 -1
Lines 14764 14756 -8
Branches 1877 1877
============================================
+ Hits 12205 12208 +3
+ Misses 1796 1787 -9
+ Partials 763 761 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kotwanikunal
approved these changes
Mar 11, 2026
Member
|
CIs can be re-run post #3155 merge. |
navneet1v
approved these changes
Mar 11, 2026
Contributor
Author
|
@navneet1v wondering if anything is holding this change off? thanks! |
Collaborator
|
@reta nothing is holding up. Its just CIs and updated code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move test codecs to test sources
Related Issues
There are no compelling reasons to keep test codecs available in production code.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.