Fix default encoder to SQ 1 bit for faiss 32x compression#3210
Open
kotwanikunal wants to merge 4 commits intoopensearch-project:mainfrom
Open
Fix default encoder to SQ 1 bit for faiss 32x compression#3210kotwanikunal wants to merge 4 commits intoopensearch-project:mainfrom
kotwanikunal wants to merge 4 commits intoopensearch-project:mainfrom
Conversation
kotwanikunal
force-pushed
the
default-encoder-faiss-32x
branch
3 times, most recently
from
467b1c3 to
beadab6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3210 +/- ##
============================================
+ Coverage 83.11% 83.24% +0.12%
- Complexity 4210 4221 +11
============================================
Files 453 453
Lines 15455 15458 +3
Branches 1972 1974 +2
============================================
+ Hits 12846 12868 +22
+ Misses 1814 1794 -20
- Partials 795 796 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
kotwanikunal
force-pushed
the
default-encoder-faiss-32x
branch
from
beadab6 to
5bac4a2
Compare
kotwanikunal
changed the title
kotwanikunal
requested review from
0ctopus13prime,
VijayanB,
Vikasht34,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan,
shatejas and
vamshin
as code owners
navneet1v
reviewed
Mar 27, 2026
Collaborator
navneet1v
left a comment
navneet1v
left a comment
There was a problem hiding this comment.
One small comment. Will wait for all CIs to complete before approving
Comment on lines
+157
to
+158
| // When auto-resolved to bits=1, remove the type and clip defaults that were injected — | ||
| // the 1-bit quantization path doesn't use them, and validateEncoderConfig would reject them. |
Collaborator
There was a problem hiding this comment.
why there is injection of Clip when 1-bit is there?
Member
Author
There was a problem hiding this comment.
The default for SQ faiss injects clip as a parameter by default - https://github.com/opensearch-project/k-NN/blame/44df2eb082b2ca68c6b2d5d2519aa23f2008931b/src/main/java/org/opensearch/knn/index/engine/faiss/FaissSQEncoder.java#L88-L93
For 1-bit we want to prevent clip or type from being resolved within the mappings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Related - #3169
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.