[Bug-fix] Ensure Prefetch setting doesn't trigger native cache rebuild#3217
Merged
navneet1v merged 2 commits intoopensearch-project:mainfrom Mar 27, 2026
Merged
[Bug-fix] Ensure Prefetch setting doesn't trigger native cache rebuild#3217navneet1v merged 2 commits intoopensearch-project:mainfrom
navneet1v merged 2 commits intoopensearch-project:mainfrom
Conversation
navneet1v
requested review from
0ctopus13prime,
VijayanB,
Vikasht34,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
ryanbogan,
shatejas and
vamshin
as code owners
Signed-off-by: Navneet Verma <navneev@amazon.com>
navneet1v
added
Bug Fixes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
=========================================
Coverage 83.11% 83.11%
- Complexity 4209 4210 +1
=========================================
Files 453 453
Lines 15450 15455 +5
Branches 1972 1972
=========================================
+ Hits 12841 12846 +5
Misses 1814 1814
Partials 795 795 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/main/java/org/opensearch/knn/common/featureflags/KNNFeatureFlags.java
Show resolved
Hide resolved
kotwanikunal
approved these changes
Mar 27, 2026
0ctopus13prime
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure Prefetch setting doesn't trigger native cache rebuild.
The problem was all the FF was going into cache rebuild consumer. I have separated them out to ensure that we have different function to get settings which rebuilds cache.
Related Issues
NA
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.