[Bug fix] Fix Lucene SQ Encoder behavior to not resolve encoder bits if user does not provide them with the encoder#3219
Merged
shatejas merged 3 commits intoopensearch-project:mainfrom Mar 31, 2026
Conversation
jack-hung-lgtm
requested review from
0ctopus13prime,
VijayanB,
Vikasht34,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan,
shatejas and
vamshin
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3219 +/- ##
============================================
+ Coverage 83.01% 83.03% +0.01%
- Complexity 4160 4163 +3
============================================
Files 447 447
Lines 15313 15317 +4
Branches 1964 1965 +1
============================================
+ Hits 12712 12718 +6
+ Misses 1808 1806 -2
Partials 793 793 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/main/java/org/opensearch/knn/index/engine/lucene/LuceneHNSWMethodResolver.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/index/engine/lucene/LuceneHNSWMethodResolverTests.java
Show resolved
Hide resolved
…to not resolve bits when user provides encoder in newest version Signed-off-by: Jack Hung <jjhung66@alumni.stanford.edu>
jack-hung-lgtm
force-pushed
the
lucene-sq-it
branch
from
ee5829c to
7503b40
Compare
jack-hung-lgtm
changed the title
Vikasht34
approved these changes
Mar 30, 2026
Collaborator
Vikasht34
left a comment
Vikasht34
left a comment
There was a problem hiding this comment.
Thanks for Fixing this , Looks good to me !!
navneet1v
approved these changes
Mar 30, 2026
kotwanikunal
approved these changes
Mar 30, 2026
navneet1v
added a commit
that referenced
this pull request
Apr 1, 2026
…to not resolve bits when user provides encoder in newest version (#3219) (#3238) (cherry picked from commit 167cc88) Signed-off-by: Jack Hung <jjhung66@alumni.stanford.edu> Signed-off-by: Naveen Tatikonda <navtat@amazon.com> Co-authored-by: jack-hung-lgtm <jjhung66@alumni.stanford.edu> Co-authored-by: Navneet Verma <navneev@amazon.com> Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added some more ITs to verify Lucene SQ Encoder Mapping Validation Behavior. Also makes sure that Lucene SQ encoder now throws validation errors if user provides encoders without bits specified in indices created after version 3.6
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.