Skip to content

Add BwC tests for Faiss SQ 1 bit and 16 bit#3223

Merged
navneet1v merged 1 commit into
opensearch-project:mainfrom
kotwanikunal:faiss-bbq-encoder
Mar 31, 2026
Merged

Add BwC tests for Faiss SQ 1 bit and 16 bit#3223
navneet1v merged 1 commit into
opensearch-project:mainfrom
kotwanikunal:faiss-bbq-encoder

Conversation

@kotwanikunal
Copy link
Copy Markdown
Member

Description

  • Adds in BWC tests for Faiss SQ 1 bit and 16 bit compatibility

Related Issues

Related - #3169

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

VijayanB
VijayanB previously approved these changes Mar 28, 2026
Copy link
Copy Markdown
Collaborator

@navneet1v navneet1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small clarifying comments added. Overall looks good.

@kotwanikunal kotwanikunal force-pushed the faiss-bbq-encoder branch 3 times, most recently from d2cb328 to 725c046 Compare March 31, 2026 21:37
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@kotwanikunal kotwanikunal changed the title Add BwC tests for Faiss SQ 1 bit Add BwC tests for Faiss SQ 1 bit and 16 bit Mar 31, 2026
@navneet1v navneet1v merged commit 12dcda3 into opensearch-project:main Mar 31, 2026
40 checks passed
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Mar 31, 2026
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 12dcda3)
0ctopus13prime pushed a commit that referenced this pull request Apr 1, 2026
(cherry picked from commit 12dcda3)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
naveentatikonda pushed a commit to naveentatikonda/k-NN that referenced this pull request Apr 7, 2026
…h-project#3243)

(cherry picked from commit 12dcda3)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
naveentatikonda pushed a commit to naveentatikonda/k-NN that referenced this pull request Apr 7, 2026
…h-project#3243)

(cherry picked from commit 12dcda3)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
ajw711 pushed a commit to ajw711/k-NN that referenced this pull request Apr 15, 2026
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants