Skip to content

fix breaking changes from opensearch core#1182

Closed
ylwu-amzn wants to merge 2 commits intoopensearch-project:2.xfrom
ylwu-amzn:2.9_fix-pr2
Closed

fix breaking changes from opensearch core#1182
ylwu-amzn wants to merge 2 commits intoopensearch-project:2.xfrom
ylwu-amzn:2.9_fix-pr2

Conversation

@ylwu-amzn
Copy link
Copy Markdown
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn
Copy link
Copy Markdown
Collaborator Author

Don't review this PR now, find more breaking changes.

@saratvemulapalli
Copy link
Copy Markdown
Member

I didnt realize there are multiple PRs already trying to fix the build, I was chasing a bug #1179 and ended up with compile problems.
Feel free to use changes from this PR: #1189

@ylwu-amzn
Copy link
Copy Markdown
Collaborator Author

I didnt realize there are multiple PRs already trying to fix the build, I was chasing a bug #1179 and ended up with compile problems. Feel free to use changes from this PR: #1189

Thanks Sarat, I will close this draft PR.

@ylwu-amzn ylwu-amzn closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants