[FEATURE] Improve test coverage for MLHttpClientFactory.java

[akolarkunnu]

Description

Improved the test coverage by adding edge cases.
The if check (bytes.length != 4) is an unreachable code, Inet4Address always will have array of 4 bytes address.

Related Issues

Resolves #1379

Check List

• New functionality includes testing.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[akolarkunnu]

Code Coverage report after fix:

The if check (bytes.length != 4) is an unreachable code, Inet4Address always will have array of 4 bytes address.
All the misses of branch coverage is due to Hex format of ip addresses. It's not important for Inet4Address type.

[akolarkunnu]

linux (21) - Known flaky org.opensearch.ml.rest.RestMLRemoteInferenceIT.testPredictWithAutoDeployAndTTL_RemoteModel #3544

Windows (23) - This is a test only change, failures are not related to the code changes.

[akolarkunnu]

Hi Maintainers, Any comments, please.

[dhrubo-os]

Tests with failures:
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testPredictWithAutoDeployAndTTL_RemoteModel

Can you take updates from main?

[akolarkunnu]

Tests with failures:
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testPredictWithAutoDeployAndTTL_RemoteModel

Can you take updates from main?

Done.

[dhrubo-os]

* What went wrong:
Execution failed for task ':opensearch-ml-plugin:compileTestJava'.
> Compilation failed; see the compiler output below.
  Note: Some input files use unchecked or unsafe operations.
  Note: Recompile with -Xlint:unchecked for details.
  Note: Recompile with -Xlint:deprecation for details.
  Note: Some input files use or override a deprecated API.
  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/tools/PromptHandler.java:18: error: cannot find symbol
          return prompt.contains(llmThought().getQuestion());
                                             ^
    symbol:   method getQuestion()
    location: class LLMThought
  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/tools/PromptHandler.java:35: error: cannot find symbol
                  + this.llmThought().getAction()
                                     ^
    symbol:   method getAction()
    location: class LLMThought
  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/tools/PromptHandler.java:38: error: cannot find symbol
                  + this.llmThought().getActionInput()
                                     ^
    symbol:   method getActionInput()
    location: class LLMThought
  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/tools/MockLLM.java:40: error: cannot find symbol
                      llmResponse.setCompletion(promptHandler.response(prompt));
                                 ^
    symbol:   method setCompletion(String)
    location: variable llmResponse of type LLMResponse
  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/tools/VisualizationsToolIT.java:36: error: cannot find symbol
                      .builder()
                      ^
    symbol:   method builder()
    location: class LLMThought
  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/tools/VisualizationsToolIT.java:46: error: cannot find symbol
                      .builder()
                      ^
    symbol:   method builder()
    location: class LLMThought
  /__w/ml-commons/ml-commons/plugin/src/test/java/org/opensearch/ml/utils/TestHelper.java:15: error: cannot find symbol
  import static org.opensearch.cluster.node.DiscoveryNodeRole.SEARCH_ROLE;
  ^
    symbol:   static SEARCH_ROLE
    location: class DiscoveryNodeRole

This PR is merged. Please rebase again.

[akolarkunnu]

This PR is merged. Please rebase again.

Ok, done.

[dhrubo-os]

Thanks @akolarkunnu for working on this. Merging the PR.