Fix test_cohereInference_withDifferent_postProcessFunction flaky test#3666
Closed
nathaliellenaa wants to merge 2 commits intoopensearch-project:mainfrom
Closed
Fix test_cohereInference_withDifferent_postProcessFunction flaky test#3666nathaliellenaa wants to merge 2 commits intoopensearch-project:mainfrom
nathaliellenaa wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
nathaliellenaa
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
rbhavna,
xinyual,
ylwu-amzn and
zane-neo
as code owners
nathaliellenaa
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
nathaliellenaa
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
mingshl
reviewed
Mar 17, 2025
Collaborator
mingshl
left a comment
mingshl
left a comment
There was a problem hiding this comment.
Thanks @nathaliellenaa for picking this up. LGTM, let's see if the integ pass and verify this fix.
after this PR is merged, you can rebase your the other branch and push again, it should unblock your another PR
dhrubo-os
reviewed
Mar 17, 2025
| assertEquals(errorMsg, 1, output.size()); | ||
| assertTrue(errorMsg, output.get(0) instanceof Map); | ||
| validateOutput(errorMsg, (Map) output.get(0), DATA_TYPE.get(postProcessFunction)); | ||
| if (output != null && DATA_TYPE != null) { |
Collaborator
There was a problem hiding this comment.
DATA_TYPE is a static variable which already have values in it. So checking null for DATA_TYPE isn't adding any value because it will not be null.
Contributor
Author
There was a problem hiding this comment.
Got it, I'll remove the null check for DATA_TYPE.
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
nathaliellenaa
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
nathaliellenaa
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
nathaliellenaa
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
nathaliellenaa
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
akolarkunnu
reviewed
Mar 18, 2025
| assertEquals(errorMsg, 1, output.size()); | ||
| assertTrue(errorMsg, output.get(0) instanceof Map); | ||
| validateOutput(errorMsg, (Map) output.get(0), DATA_TYPE.get(postProcessFunction)); | ||
| if (output != null) { |
Contributor
There was a problem hiding this comment.
Here adding null check for output won't make any difference. If output is null, it would have thrown NullPointerException at line number 79 - output.size().
Here actual issue is in line number 91, outputList.get(0)).get("data_type"). This is becoming null.
Collaborator
There was a problem hiding this comment.
I don't think we need this PR as the failure IT should already fixed, please check this comment: #3628 (comment)
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
Contributor
Author
|
Closing this PR since the fix is already made in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
test_cohereInference_withDifferent_postProcessFunctionflaky test due toRelated Issues
Resolves #3628 (comment)
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.