[Backport 3.0] moving ML-Commons Settings from plugin module to common module#3796
Merged
[Backport 3.0] moving ML-Commons Settings from plugin module to common module#3796
Conversation
* moving ML-Commons Settings from plugin module to commond module Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressed comment Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * removed extra semi colon Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * apply spotless Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * added unit tests for the settings classes Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit 9e417e6)
opensearch-trigger-bot
bot
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
rbhavna,
xinyual,
ylwu-amzn and
zane-neo
as code owners
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
mingshl
approved these changes
Apr 29, 2025
ylwu-amzn
approved these changes
Apr 29, 2025
Collaborator
|
Approved to unblock #3781 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 9e417e6 from #3764