Downgrade MCP version to 0.9 by rithin-pullela-aws · Pull Request #3821 · opensearch-project/ml-commons

rithin-pullela-aws · 2025-05-01T05:56:01Z

Description

We are using the 0.9 version of MCP to make it compatible with MCP server and also, the MCP have back ported the custom headers change to 0.9 (initially anticipated for 0.10)

Removed the extra content type header since it is being added by MCP client by default.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

New functionality includes testing.
New functionality has been documented.
API changes companion pull request created.
Commits are signed per the DCO using --signoff.
Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>

pyek-bot · 2025-05-01T06:02:54Z

plugin/build.gradle

    resolutionStrategy.force "jakarta.json:jakarta.json-api:2.1.3"
    resolutionStrategy.force "org.opensearch:opensearch:${opensearch_version}"
    resolutionStrategy.force "org.bouncycastle:bcprov-jdk18on:1.78.1"
+    resolutionStrategy.force 'io.projectreactor:reactor-core:3.7.0'


is there any conflict? why is this needed?

peterzhuamazon

Do we need this for RC3?

peterzhuamazon · 2025-05-01T06:28:07Z

ml-algorithms/build.gradle

    implementation group: 'org.json', name: 'json', version: '20231013'
    implementation group: 'software.amazon.awssdk', name: 'netty-nio-client', version: "2.30.18"
-    // TODO: Replace the custom jar with dependency implementation 'io.modelcontextprotocol.sdk:mcp:0.10.0' after its release
-    api files('libs/mcp-0.10.0-SNAPSHOT.jar')


Shall we remove the libs folder and this jar then?

https://github.com/opensearch-project/ml-commons/blob/main/ml-algorithms/libs/mcp-0.10.0-SNAPSHOT.jar

We need to use 0.9.0 instead of 0.10.0 jar.

It makes sense to remove the libs folder as we don't need it now.

Since he is already pulling dep from maven there is no reason to have the libs folder at local with a 0.10 version of the jar.

zane-neo · 2025-05-01T12:13:38Z

Do we need this for RC3?

This is required for RC3.

zane-neo · 2025-05-01T12:13:53Z

Approve to unblock RC3.

codecov · 2025-05-01T13:37:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (ed4f09f) to head (6f33d5f).
Report is 10 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3821      +/-   ##
============================================
- Coverage     78.20%   78.00%   -0.20%     
- Complexity     7162     7316     +154     
============================================
  Files           631      655      +24     
  Lines         32248    32996     +748     
  Branches       3666     3707      +41     
============================================
+ Hits          25219    25738     +519     
- Misses         5465     5672     +207     
- Partials       1564     1586      +22

Flag	Coverage Δ
ml-commons	`78.00% <ø> (-0.20%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> (cherry picked from commit 2dfbfc7)

* [BUG] Agent Framework: Handle model response when toolUse is not accompanied by text (#3755) * fix: handle model response when toolUse is not accompanied by text Signed-off-by: Pavan Yekbote <pybot@amazon.com> * feat: add test case for parseLLMOutput Signed-off-by: Pavan Yekbote <pybot@amazon.com> --------- Signed-off-by: Pavan Yekbote <pybot@amazon.com> * [BUG] Allow user to control react agent max_interations value to prevent empty response (#3756) * fix: expose max_iteration for react Signed-off-by: Pavan Yekbote <pybot@amazon.com> * fix: defaults for agent execution and differentiate between step and step result Signed-off-by: Pavan Yekbote <pybot@amazon.com> * fix: return react agent id in agent response to expose more details Signed-off-by: Pavan Yekbote <pybot@amazon.com> * spotless Signed-off-by: Pavan Yekbote <pybot@amazon.com> * fix: remove test prompt from react system prompt Signed-off-by: Pavan Yekbote <pybot@amazon.com> * refactor: rename parameters exposed to user to executor Signed-off-by: Pavan Yekbote <pybot@amazon.com> * fix: give user complete control over planner system prompt Signed-off-by: Pavan Yekbote <pybot@amazon.com> --------- Signed-off-by: Pavan Yekbote <pybot@amazon.com> * Clean up JSM from MCP (#3773) Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> * [Bug] ListTools call does not return tool attributes (#3785) * initial commit for MCP server in OpenSearch (#3781) * initial commit for MCP server in OpenSearch Signed-off-by: zane-neo <zaniu@amazon.com> * Make change to support register or remove tools across cluster Signed-off-by: zane-neo <zaniu@amazon.com> * format code Signed-off-by: zane-neo <zaniu@amazon.com> * fix UT failure caused by code change Signed-off-by: zane-neo <zaniu@amazon.com> * format code Signed-off-by: zane-neo <zaniu@amazon.com> * format code Signed-off-by: zane-neo <zaniu@amazon.com> * add license header Signed-off-by: zane-neo <zaniu@amazon.com> * fix notifications initialized not respond issue Signed-off-by: zane-neo <zaniu@amazon.com> * fix minor issues and add UTs Signed-off-by: zane-neo <zaniu@amazon.com> * Add more UTs Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> * Remove beta1 qualifier (#3794) (#3795) (cherry picked from commit 3f503f1) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> * [AUTO] Increment version to 3.1.0-SNAPSHOT (#3789) * Increment version to 3.1.0-SNAPSHOT Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Update build.gradle Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> * add release note for 3.0 (#3792) Signed-off-by: Mingshi Liu <mingshl@amazon.com> * support MCP session management (#3803) * support MCP session management Signed-off-by: zane-neo <zaniu@amazon.com> * Addressing comments Signed-off-by: zane-neo <zaniu@amazon.com> * add feature flag for mcp server and renaming mcp connector feature flag Signed-off-by: zane-neo <zaniu@amazon.com> * Address critical comments in #3781 Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> * upgrade http client to version align with core (#3809) * upgrade http client to versoin align with core Signed-off-by: zane-neo <zaniu@amazon.com> * upgrade httpclient-h2 to correct versiono Signed-off-by: zane-neo <zaniu@amazon.com> * use placeholder approach Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> * support customized message endpoint and addressing comments (#3810) * support customized message endpoint and addressing comments Signed-off-by: zane-neo <zaniu@amazon.com> * fix UT failures Signed-off-by: zane-neo <zaniu@amazon.com> * add files to jacoco exception Signed-off-by: zane-neo <zaniu@amazon.com> * fix tool name issue and optimize register tool api Signed-off-by: zane-neo <zaniu@amazon.com> * fix schema not parsed correctly issue and NPE when parameters is null Signed-off-by: zane-neo <zaniu@amazon.com> * fix failure UT Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com> * excluding circuit breaker for Agent (#3814) Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * change release note (#3811) * change release note Signed-off-by: zane-neo <zaniu@amazon.com> * Update opensearch-ml-common.release-notes-3.0.0.0.md * Update opensearch-ml-common.release-notes-3.0.0.0.md * Update opensearch-ml-common.release-notes-3.0.0.0.md --------- Signed-off-by: zane-neo <zaniu@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> * Downgrade MCP version to 0.9 (#3821) Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> * remove libs folder (#3824) Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add more logging to deploy/undeploy flows for better debugging (#3825) * add more logging to deploy/undeploy flows for better debugging Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * Fix python client not able to connect to MCP server issue (#3822) Signed-off-by: zane-neo <zaniu@amazon.com> Co-authored-by: Dhrubo Saha <dhrubo@amazon.com> * exclude trusted connector check for hidden model (#3838) Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * adding tenantId to the connector executor when this is inline connector (#3837) * adding tenantId to the connector executor when this is inline connector Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * added more unit tests Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Pavan Yekbote <pybot@amazon.com> Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> Signed-off-by: zane-neo <zaniu@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> Co-authored-by: Pavan Yekbote <pybot@amazon.com> Co-authored-by: Rithin Pullela <rithinp@amazon.com> Co-authored-by: zane-neo <zaniu@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Mingshi Liu <mingshl@amazon.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com> Co-authored-by: Bhavana Goud Ramaram <rbhavna@amazon.com>

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>

Downgrade MCP version to 0.9

6f33d5f

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>

rithin-pullela-aws requested review from HenryL27, Zhangxunmt, austintlee, b4sjoo, dhrubo-os, jngz-es, mingshl, model-collapse, rbhavna, xinyual, ylwu-amzn and zane-neo as code owners May 1, 2025 05:56

rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval May 1, 2025 05:57 — with GitHub Actions Inactive

pyek-bot reviewed May 1, 2025

View reviewed changes

peterzhuamazon reviewed May 1, 2025

View reviewed changes

peterzhuamazon mentioned this pull request May 1, 2025

[RELEASE] Release version 3.0.0 opensearch-project/opensearch-build#3747

Closed

66 tasks

zane-neo approved these changes May 1, 2025

View reviewed changes

zane-neo added the backport 3.0 label May 1, 2025

rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval May 1, 2025 13:38 — with GitHub Actions Inactive

ylwu-amzn approved these changes May 1, 2025

View reviewed changes

ylwu-amzn merged commit 2dfbfc7 into opensearch-project:main May 1, 2025
14 of 15 checks passed

opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2025

Downgrade MCP version to 0.9 (#3821)

406d4ee

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> (cherry picked from commit 2dfbfc7)

opensearch-trigger-bot bot mentioned this pull request May 1, 2025

[Backport 3.0] Downgrade MCP version to 0.9 #3823

Merged

ylwu-amzn mentioned this pull request May 1, 2025

remove libs folder #3824

Merged

5 tasks

mingshl pushed a commit that referenced this pull request May 1, 2025

Downgrade MCP version to 0.9 (#3821) (#3823)

68b6802

akolarkunnu pushed a commit to akolarkunnu/ml-commons that referenced this pull request Jun 6, 2025

Downgrade MCP version to 0.9 (opensearch-project#3821)

4ca8c74

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>

This was referenced Jan 10, 2026

docs: add MCP (Model Context Protocol) report for v3.1.0 tkykenmt/opensearch-feature-explorer#972

Merged

[bugfix] MCP (Model Context Protocol) tkykenmt/opensearch-feature-explorer#887

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Downgrade MCP version to 0.9#3821

Downgrade MCP version to 0.9#3821
ylwu-amzn merged 1 commit intoopensearch-project:mainfrom
rithin-pullela-aws:downGradeMCP

rithin-pullela-aws commented May 1, 2025

Uh oh!

pyek-bot May 1, 2025

Uh oh!

peterzhuamazon left a comment

Uh oh!

peterzhuamazon May 1, 2025

Uh oh!

zane-neo May 1, 2025

Uh oh!

zane-neo May 1, 2025

Uh oh!

peterzhuamazon May 1, 2025

Uh oh!

zane-neo commented May 1, 2025

Uh oh!

zane-neo commented May 1, 2025

Uh oh!

codecov bot commented May 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rithin-pullela-aws commented May 1, 2025

Description

Related Issues

Check List

Uh oh!

pyek-bot May 1, 2025

Choose a reason for hiding this comment

Uh oh!

peterzhuamazon left a comment

Choose a reason for hiding this comment

Uh oh!

peterzhuamazon May 1, 2025

Choose a reason for hiding this comment

Uh oh!

zane-neo May 1, 2025

Choose a reason for hiding this comment

Uh oh!

zane-neo May 1, 2025

Choose a reason for hiding this comment

Uh oh!

peterzhuamazon May 1, 2025

Choose a reason for hiding this comment

Uh oh!

zane-neo commented May 1, 2025

Uh oh!

zane-neo commented May 1, 2025

Uh oh!

codecov bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented May 1, 2025 •

edited

Loading