Remove jackson-databind and jackson-annotations dependencies now coming from core#651
Closed
b4sjoo wants to merge 1 commit intoopensearch-project:2.xfrom
Closed
Remove jackson-databind and jackson-annotations dependencies now coming from core#651b4sjoo wants to merge 1 commit intoopensearch-project:2.xfrom
b4sjoo wants to merge 1 commit intoopensearch-project:2.xfrom
Conversation
… from core Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #651 +/- ##
============================================
+ Coverage 79.86% 84.06% +4.19%
- Complexity 927 970 +43
============================================
Files 92 92
Lines 3522 3540 +18
Branches 324 326 +2
============================================
+ Hits 2813 2976 +163
+ Misses 586 427 -159
- Partials 123 137 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ylwu-amzn
approved these changes
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sicheng Song sicheng.song@outlook.com
Description
jackson-databind and jackson-annotations were added as api dependencies in server of opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars.
PR in core where the dependencies are added: opensearch-project/OpenSearch#5366
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.