Conversation
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
============================================
- Coverage 70.79% 61.36% -9.43%
Complexity 112 112
============================================
Files 124 73 -51
Lines 3951 2472 -1479
Branches 617 265 -352
============================================
- Hits 2797 1517 -1280
+ Misses 974 778 -196
+ Partials 180 177 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
| force "org.apache.httpcomponents.core5:httpcore5:${versions.httpcore5}" // resolve for amazonaws | ||
| force "joda-time:joda-time:2.8.1" // Resolve for amazonaws | ||
| force "com.fasterxml.jackson.core:jackson-core:${versions.jackson}" // resolve for amazonaws | ||
| force "com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}" // resolve for amazonaws |
There was a problem hiding this comment.
Please change:
force "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.11.4" // resolve for amazonaws
force "com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.11.4" // resolve for amazonaws
force "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.11.4" // resolve for amazonaws
to
force "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:${versions.jackson}" // resolve for amazonaws
force "com.fasterxml.jackson.dataformat:jackson-dataformat-smile:${versions.jackson}" // resolve for amazonaws
force "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:${versions.jackson}" // resolve for amazonaws
|
Given that the only failures are known flaky tests from the OpenSearch Dashboards side and the errors on the security test CI which is being tracked in #580, let's merge this in to bump Notifications to 3.0 and unblock downstream plugins and continue investigating #580 and follow-up on that afterwards since it seems to be coming from a core dependency change and not from Notifications itself. |
Signed-off-by: Ashish Agrawal ashisagr@amazon.com
Description
Bump version to 3.0
Issues Resolved
#481
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.