Skip to content

Bump to 3.0#556

Merged
qreshi merged 11 commits intoopensearch-project:mainfrom
lezzago:bump-to-3.0
Dec 16, 2022
Merged

Bump to 3.0#556
qreshi merged 11 commits intoopensearch-project:mainfrom
lezzago:bump-to-3.0

Conversation

@lezzago
Copy link
Copy Markdown
Member

@lezzago lezzago commented Oct 27, 2022

Signed-off-by: Ashish Agrawal ashisagr@amazon.com

Description

Bump version to 3.0

Issues Resolved

#481

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago requested a review from a team October 27, 2022 15:27
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #556 (7296315) into main (fb31fa4) will decrease coverage by 9.42%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #556      +/-   ##
============================================
- Coverage     70.79%   61.36%   -9.43%     
  Complexity      112      112              
============================================
  Files           124       73      -51     
  Lines          3951     2472    -1479     
  Branches        617      265     -352     
============================================
- Hits           2797     1517    -1280     
+ Misses          974      778     -196     
+ Partials        180      177       -3     
Flag Coverage Δ
dashboards-notifications ?
opensearch-notifications 61.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...earch/notifications/spi/utils/ValidationHelpers.kt 43.33% <ø> (ø)
...arch/notifications/core/utils/ValidationHelpers.kt 28.00% <ø> (ø)
...notifications/core/client/DestinationHttpClient.kt 86.76% <100.00%> (ø)
...otifications/public/components/Modal/ModalRoot.tsx
...notifications/public/pages/Emails/CreateSender.tsx
...ns/public/components/ContentPanel/ContentPanel.tsx
...es/Emails/components/forms/CreateSESSenderForm.tsx
...ions/public/pages/Emails/utils/validationHelper.ts
dashboards-notifications/server/utils/helper.ts
...ions/public/pages/Notifications/utils/constants.ts
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago and others added 5 commits November 14, 2022 08:45
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
force "org.apache.httpcomponents.core5:httpcore5:${versions.httpcore5}" // resolve for amazonaws
force "joda-time:joda-time:2.8.1" // Resolve for amazonaws
force "com.fasterxml.jackson.core:jackson-core:${versions.jackson}" // resolve for amazonaws
force "com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}" // resolve for amazonaws
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change:

force "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.11.4" // resolve for amazonaws
force "com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.11.4" // resolve for amazonaws
force "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.11.4" // resolve for amazonaws

to

force "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:${versions.jackson}" // resolve for amazonaws
force "com.fasterxml.jackson.dataformat:jackson-dataformat-smile:${versions.jackson}" // resolve for amazonaws
force "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:${versions.jackson}" // resolve for amazonaws

@qreshi
Copy link
Copy Markdown
Contributor

qreshi commented Dec 16, 2022

Given that the only failures are known flaky tests from the OpenSearch Dashboards side and the errors on the security test CI which is being tracked in #580, let's merge this in to bump Notifications to 3.0 and unblock downstream plugins and continue investigating #580 and follow-up on that afterwards since it seems to be coming from a core dependency change and not from Notifications itself.

@qreshi qreshi merged commit 5b9ff98 into opensearch-project:main Dec 16, 2022
@lezzago lezzago mentioned this pull request Jan 19, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants