Add search and warm node roles#1006
Open
moesterheld wants to merge 1 commit intoopensearch-project:mainfrom
Open
Add search and warm node roles#1006moesterheld wants to merge 1 commit intoopensearch-project:mainfrom
search and warm node roles#1006moesterheld wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Matthias Oesterheld <matthias.oesterheld@graylog.com>
moesterheld
requested review from
Tokesh,
VachaShah,
Xtansia,
aabeshov,
harshavamsi,
karenyrx,
lucy66hw and
sachetalva
as code owners
Author
|
anybody willing to take a look at this and my other prs I added in December? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the node roles
searchandwarmto the roles constants.searchhas been available for a long while for searchable snapshots and renamed towarmin 3.0Issues Resolved
fixes opensearch-project/opensearch-java#893
(although it should be discussed if a static list of roles should be used as in theory any role defined in the node configuration would be provided and possibly break apis, as is the case for the java client)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.