Adds command line argument to specify throughput percentiles to display#449
Merged
IanHoang merged 1 commit intoopensearch-project:mainfrom Jan 30, 2024
Merged
Conversation
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
IanHoang
approved these changes
Jan 30, 2024
Collaborator
IanHoang
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this @peteralfonsi
Since --throughput-percentiles and --latency-percentiles are new command line arguments, we should also have this reflected in the reference guide for documentation website. It's not needed ASAP but will be needed by the time of our next release. I'll create an issue for this
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new optional argument,
--throughput-percentiles. Similar to #441, the user can send a comma-separated list of throughput percentiles they'd like to see displayed at the end of the run. The original stats (max, min, median, mean) are always displayed regardless of--throughput-percentiles.Example usage:
opensearch-benchmark execute-test --pipeline=benchmark-only --workload-path=/home/ec2-user/osb/opensearch-benchmark-workloads/modified_nyc_taxis --target-host=http://localhost:9200/ --throughput-percentiles 10,50,75Result (trimmed):
(Note - if the user is specifying percentiles, I'm assuming they want accuracy, so I left it displaying all 4 decimal places. But if you guys think I should change it to 2 places to align with min/median/mean/max, I can change that)
Issues Resolved
Resolves #261
Testing
Changes to percentile sample size function were tested in its UT. Manually tested on a workload, with all combinations of throughput and latency percentiles being on and off, to ensure the values were as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.