Skip to content

Enables vector derived source 3.0 benchmarks#5430

Merged
rishabh6788 merged 1 commit into
opensearch-project:mainfrom
jmazanec15:enabled-derived-source
Apr 1, 2025
Merged

Enables vector derived source 3.0 benchmarks#5430
rishabh6788 merged 1 commit into
opensearch-project:mainfrom
jmazanec15:enabled-derived-source

Conversation

@jmazanec15
Copy link
Copy Markdown
Member

Description

Enables vector derived source for 3.0 benchmarks.

In OSB, this change was added in opensearch-project/opensearch-benchmark-workloads@eddbd62.

In addition, in nightly graphs, how can I add index size as a metric?

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15
Copy link
Copy Markdown
Member Author

Seeing

TestRunNonSecBenchmarkTestScript > testRunNonSecurityBenchmarkTestScript_verifyPipeline FAILED
    org.opentest4j.AssertionFailedError: [If you intended to update the callstack, use JVM parameter -Dpipeline.stack.write=true] 
    expected: "   benchmark-test.run()
          benchmark-test.modernSCM({$class=GitSCMSource, remote=[https://github.com/opensearch-project/opensearch-build-libraries.git})](https://github.com/opensearch-project/opensearch-build-libraries.git%7D))
          benchmark-test.library({identifier=jenkins@7.0.0, retriever=null})
          benchmark-test.pipeline(groovy.lang.Closure)
             benchmark-test.timeout({time=24, unit=HOURS})
             benchmark-test.logRotator({daysToKeepStr=30})
             benchmark-test.buildDiscarder(null)
             benchmark-test.echo(Executing on agent [label:none])
             benchmark-test.parameterizedCron(

From the test - @rishabh6788 do you know what this could be?

@rishabh6788
Copy link
Copy Markdown
Collaborator

Seeing

TestRunNonSecBenchmarkTestScript > testRunNonSecurityBenchmarkTestScript_verifyPipeline FAILED
    org.opentest4j.AssertionFailedError: [If you intended to update the callstack, use JVM parameter -Dpipeline.stack.write=true] 
    expected: "   benchmark-test.run()
          benchmark-test.modernSCM({$class=GitSCMSource, remote=[https://github.com/opensearch-project/opensearch-build-libraries.git})](https://github.com/opensearch-project/opensearch-build-libraries.git%7D))
          benchmark-test.library({identifier=jenkins@7.0.0, retriever=null})
          benchmark-test.pipeline(groovy.lang.Closure)
             benchmark-test.timeout({time=24, unit=HOURS})
             benchmark-test.logRotator({daysToKeepStr=30})
             benchmark-test.buildDiscarder(null)
             benchmark-test.echo(Executing on agent [label:none])
             benchmark-test.parameterizedCron(

From the test - @rishabh6788 do you know what this could be?

Please run below tests to generate the modified txt files, jenkins thingy.

./gradlew clean
./gradlew test -info -Ppipeline.stack.write=true --tests=TestRunNonSecBenchmarkTestScript
./gradlew test -info -Ppipeline.stack.write=true --tests=TestRunSecureBenchmarkTestScript
 ./gradlew test -info -Ppipeline.stack.write=true --tests=TestRunBenchmarkTestScriptDistributionUrl

@jmazanec15
Copy link
Copy Markdown
Member Author

jmazanec15 commented Apr 1, 2025

Thanks @rishabh6788 - seems that reverts my change for some reason. I can push it if that makes sense but Im getting

$ git commit --amend --signoff
On branch enabled-derived-source
Your branch is up to date with 'origin/enabled-derived-source'.

No changes
You asked to amend the most recent commit, but doing so would make
it empty. You can repeat your command with --allow-empty, or you can
remove the commit entirely with "git reset HEAD^".

@jmazanec15 jmazanec15 force-pushed the enabled-derived-source branch from 8b933f1 to 030d457 Compare April 1, 2025 20:39
Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 force-pushed the enabled-derived-source branch from 030d457 to 2e173af Compare April 1, 2025 20:56
@rishabh6788 rishabh6788 merged commit 150fa45 into opensearch-project:main Apr 1, 2025
13 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Apr 1, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (027ac89) to head (2e173af).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #5430   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants