Skip to content

Add 2-node topology configuration for query-insights integration tests#5917

Merged
gaiksaya merged 1 commit into
opensearch-project:mainfrom
KishoreKicha14:qi-multi-node
Jan 15, 2026
Merged

Add 2-node topology configuration for query-insights integration tests#5917
gaiksaya merged 1 commit into
opensearch-project:mainfrom
KishoreKicha14:qi-multi-node

Conversation

@KishoreKicha14
Copy link
Copy Markdown
Contributor

@KishoreKicha14 KishoreKicha14 commented Jan 15, 2026

Description

This PR fixes failing integration tests in the query-insights plugin by adding the missing topology configuration to test manifests. The QueryInsightsClusterIT test class requires a 2-node cluster to properly test multi-node functionality, but the CI configuration was only running tests on a single node by default.

Problem

The query-insights plugin has cluster-level integration tests that require multiple nodes:

  • testCrossNodeQueryInsightsDataConsistency
  • testTopQueriesNodeFiltering
  • testMultiNodeDataCollectionAndAggregation

These tests were failing in CI because the test manifests lacked topology configuration, causing them to run on the default single-node setup.

Solution

Added topology configuration to query-insights in all test manifests:

- name: query-insights
  integ-test:
    topology:
      - cluster_name: cluster
        data_nodes: 2
    test-configs:
      - with-security
      - without-security

This matches the pattern used by other plugins requiring multi-node clusters (e.g., cross-cluster-replication).

Files Changed

Updated test manifest file for version 3.5.0 to include the 2-node topology configuration.

Testing

The integration tests can now be verified with:

./gradlew ':integTest' --tests 'org.opensearch.plugin.insights.QueryInsightsClusterIT.*'

Issues Resolved

Closes [#5868]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Topology configuration is added to the query-insights integ-test block across 18 OpenSearch manifest versions (2.18.0 through 3.5.0), specifying a cluster named "cluster" with 2 data nodes. Each file receives an identical 3-line topology addition.

Changes

Cohort / File(s) Summary
Query-Insights Topology Configuration
manifests/2.18.{0,1}/opensearch-2.18.*-test.yml, manifests/2.19.{0,1,2,3,4,5}/opensearch-2.19.*-test.yml, manifests/3.0.0-{alpha1,beta1}/opensearch-3.0.0-*-test.yml, manifests/3.0.0/opensearch-3.0.0-test.yml, manifests/3.{1,2}.0/opensearch-3.{1,2}.0-test.yml, manifests/3.3.{0,1,2}/opensearch-3.3.*-test.yml, manifests/3.4.0/opensearch-3.4.0-test.yml, manifests/3.5.0/opensearch-3.5.0-test.yml
Added topology specification under query-insights integ-test with cluster name "cluster" and 2 data nodes. Change is identical and applied consistently across all 18 manifest versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: adding a 2-node topology configuration to query-insights integration tests across multiple manifest versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description clearly explains the problem, solution, and rationale for adding topology configuration to query-insights test manifests across multiple versions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.56%. Comparing base (6d523ca) to head (21b06f4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5917   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         405      405           
  Lines       18556    18556           
=======================================
  Hits        17919    17919           
  Misses        637      637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Kishore Kumaar Natarajan <kkumaarn@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants