Add 2-node topology configuration for query-insights integration tests#5917
Conversation
📝 WalkthroughWalkthroughTopology configuration is added to the query-insights integ-test block across 18 OpenSearch manifest versions (2.18.0 through 3.5.0), specifying a cluster named "cluster" with 2 data nodes. Each file receives an identical 3-line topology addition. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5917 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 405 405
Lines 18556 18556
=======================================
Hits 17919 17919
Misses 637 637 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kishore Kumaar Natarajan <kkumaarn@amazon.com>
6043bb1 to
21b06f4
Compare
Description
This PR fixes failing integration tests in the query-insights plugin by adding the missing topology configuration to test manifests. The QueryInsightsClusterIT test class requires a 2-node cluster to properly test multi-node functionality, but the CI configuration was only running tests on a single node by default.
Problem
The query-insights plugin has cluster-level integration tests that require multiple nodes:
These tests were failing in CI because the test manifests lacked topology configuration, causing them to run on the default single-node setup.
Solution
Added topology configuration to query-insights in all test manifests:
This matches the pattern used by other plugins requiring multi-node clusters (e.g., cross-cluster-replication).
Files Changed
Updated test manifest file for version 3.5.0 to include the 2-node topology configuration.
Testing
The integration tests can now be verified with:
./gradlew ':integTest' --tests 'org.opensearch.plugin.insights.QueryInsightsClusterIT.*'
Issues Resolved
Closes [#5868]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.