Skip to content

Update rustlib copy location to exactly opensearch-<version>/lib/rust (part2)#6186

Merged
peterzhuamazon merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:update-rustlib-location-3
May 6, 2026
Merged

Update rustlib copy location to exactly opensearch-<version>/lib/rust (part2)#6186
peterzhuamazon merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:update-rustlib-location-3

Conversation

@peterzhuamazon
Copy link
Copy Markdown
Member

Description

Update rustlib copy location to exactly opensearch-/lib/rust (part2)

Issues Resolved

#5810

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… (part2)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit b1690e3 into opensearch-project:main May 6, 2026
14 checks passed
@peterzhuamazon peterzhuamazon deleted the update-rustlib-location-3 branch May 6, 2026 04:08
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Path Consistency

The mkdir -p now creates $OUTPUT/lib/rust, which matches the cp destination. Previously, mkdir created $OUTPUT/../lib/rust (one level up) while cp targeted $OUTPUT/lib/rust. The fix looks correct, but it should be validated that $OUTPUT is indeed the versioned directory (e.g., opensearch-<version>) so that the final path resolves to opensearch-<version>/lib/rust as intended.

mkdir -p "$OUTPUT/lib/rust"
cp -v ../../../$DISTRIBUTION/builds/opensearch/dist/libopensearch_native.* "$OUTPUT/lib/rust"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Verify output path resolves correctly

The cp command still uses the old path "$OUTPUT/lib/rust" which is consistent with
the new mkdir -p path, but it's worth verifying that the cp destination matches the
newly created directory. Both lines now use "$OUTPUT/lib/rust", so they are
consistent — however, ensure that $OUTPUT correctly resolves to the opensearch-
directory and not a parent directory, since the intent is opensearch-/lib/rust.

scripts/components/OpenSearch-DataFusion/install.sh [123-124]

+mkdir -p "$OUTPUT/lib/rust"
+cp -v ../../../$DISTRIBUTION/builds/opensearch/dist/libopensearch_native.* "$OUTPUT/lib/rust"
 
-
Suggestion importance[1-10]: 2

__

Why: The existing_code and improved_code are identical, meaning no actual change is proposed. The suggestion only asks to verify that $OUTPUT resolves correctly, which is a validation concern rather than a code fix.

Low

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.62%. Comparing base (9b2ff04) to head (3f39741).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6186   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         405      405           
  Lines       19039    19039           
=======================================
  Hits        18397    18397           
  Misses        642      642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants