Skip to content

Adding cypress13 testing manifest on 3.6.0#6188

Merged
peterzhuamazon merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:test-cypress13-jenkins
May 6, 2026
Merged

Adding cypress13 testing manifest on 3.6.0#6188
peterzhuamazon merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:test-cypress13-jenkins

Conversation

@peterzhuamazon
Copy link
Copy Markdown
Member

Description

Adding cypress13 testing manifest on 3.6.0

Issues Resolved

opensearch-project/opensearch-dashboards-functional-test#1996

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Floating Ref

The functionalTestDashboards component uses ref: 'main' instead of a pinned tag or commit SHA. This means the manifest will pull whatever is on the main branch at test time, which can lead to non-reproducible test runs and unexpected failures if main changes.

repository: https://github.com/opensearch-project/opensearch-dashboards-functional-test.git
ref: 'main'

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Pin floating branch reference to specific version tag

The functionalTestDashboards component references the main branch instead of a
specific version tag. For a versioned release manifest like 3.6.0, using a floating
branch reference can lead to non-reproducible builds if the main branch advances.
Consider pinning this to a specific tag or commit SHA that corresponds to the 3.6.0
release.

manifests/3.6.0/opensearch-dashboards-3.6.0-cypress13.yml [22-24]

 - name: functionalTestDashboards
   repository: https://github.com/opensearch-project/opensearch-dashboards-functional-test.git
-  ref: 'main'
+  ref: tags/3.6.0.0
Suggestion importance[1-10]: 5

__

Why: The suggestion is valid - using main branch in a versioned release manifest can lead to non-reproducible builds. However, this may be intentional for cypress test manifests, as the functional test repository might not have version-specific tags matching the component pattern. The suggestion is reasonable but may not apply universally to cypress-specific manifests.

Low

@peterzhuamazon peterzhuamazon merged commit 4321f76 into opensearch-project:main May 6, 2026
17 checks passed
@peterzhuamazon peterzhuamazon deleted the test-cypress13-jenkins branch May 6, 2026 22:34
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.62%. Comparing base (8eed629) to head (57adf52).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6188   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         405      405           
  Lines       19039    19039           
=======================================
  Hits        18397    18397           
  Misses        642      642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants