Onboarding new maven snapshots publishing to s3 (opensearch-java)#1768
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
| credentials { | ||
| username = System.getenv("SONATYPE_USERNAME") | ||
| password = System.getenv("SONATYPE_PASSWORD") | ||
| credentials(AwsCredentials) { |
There was a problem hiding this comment.
credentials(AwsCredentials::class) {
There was a problem hiding this comment.
Will try, this is the first time I try this on kotlin. Thanks.
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
But this will be null until the push commit happens. We should not need to verify this during PR checks. |
I think it is not related to push - the |
In groovy version of the build.gradle in other plugins, doesnt seem to be a requirement tho. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Yeah, Kotlin builds are somewhat different, it seems like there are more issues to fix, I could help you later tonight , have to run now, sorry about that |
Signed-off-by: Andriy Redko <drreta@gmail.com>
) * Onboarding new maven snapshots publishing to s3 (opensearch-java) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Update credentials Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Set a default value for MAVEN_SNAPSHOTS_S3_REPO Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Update from 3.0.0-beta1 to 3.0.0 dependencies Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Fix MAVEN_SNAPSHOTS_S3_REPO enviroment variable usage Signed-off-by: Andriy Redko <drreta@gmail.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> (cherry picked from commit c064975) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-java/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-java/backport-2.x
# Create a new branch
git switch --create backport/backport-1768-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c064975e26d6cc9192a50289afa83fd43eac0f9e
# Push it to GitHub
git push --set-upstream origin backport/backport-1768-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-java/backport-2.xThen, create a pull request where the |
) (#1774) * Onboarding new maven snapshots publishing to s3 (opensearch-java) * Update credentials * Set a default value for MAVEN_SNAPSHOTS_S3_REPO * Update from 3.0.0-beta1 to 3.0.0 dependencies * Fix MAVEN_SNAPSHOTS_S3_REPO enviroment variable usage --------- (cherry picked from commit c064975) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com>
Description
Onboarding new maven snapshots publishing to s3 (opensearch-java)
Issues Resolved
opensearch-project/opensearch-build#5360
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.