Fixes deserialization of enums when using booleans instead of strings#482
Conversation
Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com>
patschl
requested review from
Bukhtawar,
VachaShah,
dblock,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com>
|
Before I merge, what tests would fail if |
Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com>
|
I just tried it and actually no test fails, it's just an unexpected behaviour to implicitly support boolean deserialization with the Enum Deserializer. If you'd like to I could move the new deserialization logic to the existing Deserializer. |
Yes yes! |
|
Also please update documentation/README. |
patschl
force-pushed
the
fix_enum_boolean_deserialization
branch
from
d79afc5 to
b372d24
Compare
|
I made the recommended changes and updated the CHANGELOG.md along with the Javadoc. |
Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com>
patschl
force-pushed
the
fix_enum_boolean_deserialization
branch
from
b372d24 to
125b78f
Compare
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
LGTM! No need to change anything in README.
…#482) * Fixes deserialization of enums when using booleans instead of strings Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> * Fixes CHANGELOG.md Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> * Fixes checkstyle failure Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> * Include boolean support in existing JsonEnum.Deserializer Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> --------- Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> (cherry picked from commit 5af5674) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#482) (#488) * Fixes deserialization of enums when using booleans instead of strings * Fixes CHANGELOG.md * Fixes checkstyle failure * Include boolean support in existing JsonEnum.Deserializer --------- (cherry picked from commit 5af5674) Signed-off-by: Patrick Schlindwein <patrick.schlindwein@bolindalabs.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 participants
Description
Allows for boolean values for enums which support those, eg.
DynamicMappingandRefresh.Issues Resolved
Fixes #256
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.