Moving "software.amazon.awssdk" dependencies to the compileOnly scope.#628
Merged
VachaShah merged 3 commits intoopensearch-project:mainfrom Sep 22, 2023
Merged
Moving "software.amazon.awssdk" dependencies to the compileOnly scope.#628VachaShah merged 3 commits intoopensearch-project:mainfrom
VachaShah merged 3 commits intoopensearch-project:mainfrom
Conversation
Member
|
Thanks! could you please check DCO ( |
Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com>
reta
requested changes
Sep 20, 2023
Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com>
reta
previously approved these changes
Sep 20, 2023
Collaborator
|
@dkaukov could you please add a changelog entry, thank you |
Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com>
reta
approved these changes
Sep 22, 2023
VachaShah
approved these changes
Sep 22, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-628-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 66608d3450865f6ee0d6b4e924ed7aaac74ba88d
# Push it to GitHub
git push --set-upstream origin backport/backport-628-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
VachaShah
pushed a commit
to VachaShah/opensearch-java
that referenced
this pull request
Sep 22, 2023
opensearch-project#628) * move "software.amazon.awssdk" dependencies to the compileOnly scope. Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com> * PR feedback Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com> * PR feedback Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com> --------- Signed-off-by: Dmitry Kaukov <dkaukov@opentable.com> Signed-off-by: Vacha Shah <vachshah@amazon.com>
Collaborator
|
Backport in #634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current build configuration leaking "software.amazon.awssdk" dependencies to the final POM:
Which breaks some maven plugins (notable https://github.com/basepom/dependency-versions-check-maven-plugin) which tries to download all possible versions of the SDK in range.
Issues Resolved
By changing scope to the
compileOnly, we completely removing this dependencies from final POMBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.