Pass through index aliases when checking if index closed#941
Open
tienne-B wants to merge 2 commits intoopensearch-project:mainfrom
Open
Pass through index aliases when checking if index closed#941tienne-B wants to merge 2 commits intoopensearch-project:mainfrom
tienne-B wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
tienne-B
requested review from
Shephalimittal,
VachaShah,
axeoman,
florianvazelle,
harshavamsi and
saimedhi
as code owners
Signed-off-by: Étienne Beaulé <etienne@dashsocial.com>
tienne-B
force-pushed
the
is-closed-alias
branch
from
ad59c85 to
8c5cd01
Compare
Signed-off-by: Étienne Beaulé <etienne@dashsocial.com>
Collaborator
|
Hi @tienne-B, thank you for your PR. The changes are short, so it seems fine, but it's hard for me to see the real impact of these changes. Is there a manual test I could run to test them, or a unit test that could be added ? |
Collaborator
|
@tienne-B , thank you for the contributions. Please consider adding tests and completing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation on #823 which allows for indexes to be saved through an alias. However, if there are any analyzers, the procedure will fail during the check to see if the index is closed, as it checks for the status of the alias rather than the index name which the response uses.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.