Modified local node request to return discovery node directly to caller#202
Merged
joshpalis merged 4 commits intoopensearch-project:mainfrom Oct 31, 2022
joshpalis:local-node
Merged
Modified local node request to return discovery node directly to caller#202joshpalis merged 4 commits intoopensearch-project:mainfrom joshpalis:local-node
joshpalis merged 4 commits intoopensearch-project:mainfrom
joshpalis:local-node
Conversation
Signed-off-by: Joshua Palis <jpalis@amazon.com>
6 tasks
owaiskazi19
reviewed
Oct 20, 2022
src/main/java/org/opensearch/sdk/handlers/LocalNodeResponseHandler.java
Outdated
Show resolved
Hide resolved
owaiskazi19
reviewed
Oct 20, 2022
src/main/java/org/opensearch/sdk/handlers/LocalNodeResponseHandler.java
Outdated
Show resolved
Hide resolved
dbwiddis
requested changes
Oct 21, 2022
src/main/java/org/opensearch/sdk/handlers/LocalNodeResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/LocalNodeResponseHandler.java
Outdated
Show resolved
Hide resolved
… getLocalNode to avoid naming confusion. Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
previously approved these changes
Oct 22, 2022
dbwiddis
reviewed
Oct 22, 2022
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
============================================
+ Coverage 65.86% 66.39% +0.52%
+ Complexity 103 100 -3
============================================
Files 25 24 -1
Lines 501 491 -10
Branches 17 17
============================================
- Hits 330 326 -4
+ Misses 159 153 -6
Partials 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dbwiddis
approved these changes
Oct 24, 2022
owaiskazi19
approved these changes
Oct 25, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…er (opensearch-project#202) * Modified local node request to return discovery node direfctly to caller Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing sendLocalNodeRequest, renaming getter for opensearch node to getLocalNode to avoid naming confusion. Signed-off-by: Joshua Palis <jpalis@amazon.com> * Reverting name of opensearch node getter Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Joshua Palis <jpalis@amazon.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
…er (opensearch-project#202) * Modified local node request to return discovery node direfctly to caller Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing sendLocalNodeRequest, renaming getter for opensearch node to getLocalNode to avoid naming confusion. Signed-off-by: Joshua Palis <jpalis@amazon.com> * Reverting name of opensearch node getter Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Joshua Palis <jpalis@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Palis jpalis@amazon.com
Description
Modified local node request to return discovery node directly to caller
Edit : Separate local Node Requests are not necessary to provide support for since the local node is already transported to the SDK during node initialization. There is already a getter for the opensearch node (source node) used for testing, and this can be modified in order to access this within an extension
Companion PR : opensearch-project/OpenSearch#4862
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.