Changes to add jdk17, remove jdk 8,14, OS 2.0 and upgrade to gradle 7#156
Conversation
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
…k 17 Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
============================================
- Coverage 72.02% 71.92% -0.10%
+ Complexity 2962 2949 -13
============================================
Files 376 376
Lines 18834 18783 -51
Branches 1465 1442 -23
============================================
- Hits 13565 13510 -55
+ Misses 4685 4676 -9
- Partials 584 597 +13
Continue to review full report at Codecov.
|
| excludeFilter = file("checkstyle/findbugs-exclude.xml") | ||
| effort = 'max' | ||
| ignoreFailures = false | ||
| ignoreFailures = true // TODO: Set this to false later as they are too many warnings to be fixed. |
There was a problem hiding this comment.
If we are not planning to fix this now, can we open an issue and link it here?
Looks like you fixed almost all the issues.
There was a problem hiding this comment.
I have created issue - #157 to track this.
There are still many medium related warnings which needs to be fixed. I fixed high priority ones.
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
|
Though JDK 11, 17 CI is failing, will be pushing these changes. As this RCA PR rely on PA where OS 2.0, gradle 7, jdk 17 changes are still in PR phase. Will take care there. Had tested these changes with pointing to PA non main branch which had desired changes. |
Signed-off-by: Sagar Upadhyaya sagar.upadhyaya.121@gmail.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.