Removing metrics which are not required now as were removed in OS 2.0#159
Merged
sruti1312 merged 2 commits intoopensearch-project:mainfrom Apr 8, 2022
Merged
Conversation
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
============================================
- Coverage 71.93% 71.89% -0.05%
- Complexity 2949 2951 +2
============================================
Files 376 376
Lines 18782 18747 -35
Branches 1442 1442
============================================
- Hits 13511 13478 -33
Misses 4675 4675
+ Partials 596 594 -2
Continue to review full report at Codecov.
|
dzane17
approved these changes
Apr 8, 2022
sruti1312
approved these changes
Apr 8, 2022
Contributor
|
Documentation needs to be updated that these metrics are not supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sagar Upadhyaya sagar.upadhyaya.121@gmail.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Removing segment related memory metrics as they were removed from OS 2.0 here - opensearch-project/OpenSearch@fc0d3a3.
We had removed references of these in PA as well earlier.
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.