Replace references to /_opendistro with /_plugins#16
Merged
Conversation
Member
|
This all executes client-side, right? There's nothing server-side that needs to preserve backward compatibility here? |
sruti1312
reviewed
May 21, 2021
Contributor
Author
|
@dblock The RCA app creates a server that responds to the requests on port 9600, which means we do need to make a change for backward compatibility. We will follow up this PR with one that adds backward compatibility for the |
sruti1312
reviewed
May 21, 2021
src/main/java/org/opensearch/performanceanalyzer/rest/QueryRcaRequestHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/performanceanalyzer/rest/QueryRcaRequestHandler.java
Outdated
Show resolved
Hide resolved
sruti1312
approved these changes
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Updating calls to the Performance Analyzer plugin API to follow the new
/_pluginsnaming convention.Describe the solution you are proposing
RCA behavior should be unchanged.
Describe alternatives you've considered
This is a required change to follow new OpenSearch guidelines.
Additional context
https://github.com/opensearch-project/opensearch-plugins/blob/main/UPGRADING.md#settings-backwards-compatibility
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.