Fix rpm build by adding config to env variable#172
Merged
Conversation
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
dzane17
approved these changes
Apr 27, 2022
sgup432
approved these changes
Apr 27, 2022
Comment on lines
+26
to
+34
| public static final String DEFAULT_CONFIG_FOLDER_PATH = | ||
| OPENSEARCH_HOME | ||
| + File.separator | ||
| + "config" | ||
| + File.separator | ||
| + "opensearch-performance-analyzer" | ||
| + File.separator | ||
| + "performance-analyzer.properties"; | ||
| + File.separator; | ||
| private static final String DEFAULT_CONFIG_FILE_PATH = | ||
| DEFAULT_CONFIG_FOLDER_PATH + "performance-analyzer.properties"; |
Member
There was a problem hiding this comment.
Are we still using OPENSEARCH_HOME here for the default config folder?
Contributor
Author
There was a problem hiding this comment.
Using OPENSEARCH_HOME here for the default config folder. Removing the default maybe a better idea. Any thoughts?
performance-analyzer-agent which starts the PA process will never succeed if the setting is not present, which means this DEFAULT value will never be used.
Member
There was a problem hiding this comment.
I am ok to remove the var if never used.
This was referenced Apr 27, 2022
sruti1312
added a commit
that referenced
this pull request
Apr 28, 2022
* Update configFilePath location (#172) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Disable plugin if configFilePath is not present Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312
added a commit
that referenced
this pull request
May 11, 2022
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312
added a commit
that referenced
this pull request
May 17, 2022
* Update folder names (#166) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Update PA directories from plugins to root (#168) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Update configFilePath location (#172) Signed-off-by: sruti1312 <srutiparthiban@gmail.com> * Disable plugin if configFilePath is not present (#173) Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sruti1312 srutiparthiban@gmail.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
opensearch-project/performance-analyzer#197
Describe the solution you are proposing
Checks for
opensearch.path.confbefore setting the default config value.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.