Skip to content

Addressing the spotbug failure #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khushbr merged 1 commit into from
Jul 14, 2021
Merged

Addressing the spotbug failure #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ain/java/org/opensearch/performanceanalyzer/reader_writer_shared/EventLogFileHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,10 @@ private void readInternal(Path pathToFile, int bufferSize, EventDispatcher proce
public void deleteAllFiles() {
LOG.debug("Cleaning up any leftover files.");
File root = new File(metricsLocation);
// Filter out '.tmp' files, we do not want to delete currBucket .tmp files
String[] filesToDelete = root.list((dir, name) -> !name.endsWith(TMP_FILE_EXT));
String[] filesToDelete = root.list();
if (filesToDelete == null) {
return;
}
Comment on lines +177 to +180
Copy link
Copy Markdown
Contributor

@sruti1312 sruti1312 Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should retain filtering out .tmp files check as this might delete the currentBucket .tmp files?

deleteFiles(Arrays.asList(filesToDelete));
}

Expand Down