Skip to content

Update Gradle to 7.6.1 and Gradle test-retry to 1.5.2#354

Merged
khushbr merged 3 commits intoopensearch-project:mainfrom
Tjofil:upgrade_gradle_7_6_1
Apr 28, 2023
Merged

Update Gradle to 7.6.1 and Gradle test-retry to 1.5.2#354
khushbr merged 3 commits intoopensearch-project:mainfrom
Tjofil:upgrade_gradle_7_6_1

Conversation

@Tjofil
Copy link
Copy Markdown
Contributor

@Tjofil Tjofil commented Apr 28, 2023

Due to opensearch-project/OpenSearch#7286, we are required to switch to Gradle 7.6.1.

  • Update Gradle to 7.6.1
  • Generate new Gradle wrapper
  • Update Gradle test-retry plugin to be compatible with 7.6.1 and avoid AbstractMethodError
  • Update JVM args to solve recently hidden Java packages.
  • Minor dependency version adjustments.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tjofil added 2 commits April 27, 2023 17:15
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #354 (3695a6e) into main (d6bdd7b) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 3695a6e differs from pull request most recent head 634911e. Consider uploading reports for the commit 634911e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #354      +/-   ##
============================================
- Coverage     72.77%   72.76%   -0.02%     
+ Complexity     3045     3042       -3     
============================================
  Files           381      381              
  Lines         19013    19013              
  Branches       1472     1472              
============================================
- Hits          13836    13834       -2     
- Misses         4581     4582       +1     
- Partials        596      597       +1     

see 3 files with indirect coverage changes

@khushbr
Copy link
Copy Markdown
Collaborator

khushbr commented Apr 28, 2023

The CI is failing here because of circular dependency on the PA repo, once both set of changes are merged, the build failure will be resolved.

@khushbr khushbr merged commit 426c78b into opensearch-project:main Apr 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 12, 2023
* Change gradle version to 7.6.1.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>

* Update gradle, gradle wrapper and plugin version.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>

* Uncomment test comments.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>

---------

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit 426c78b)
khushbr pushed a commit that referenced this pull request May 15, 2023
* Change gradle version to 7.6.1.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>

* Update gradle, gradle wrapper and plugin version.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>

* Uncomment test comments.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>

---------

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit 426c78b)

Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants