Skip to content

Updating the PA zip creation logic for docker build#357

Merged
khushbr merged 2 commits intoopensearch-project:mainfrom
khushbr:clone-pa-fix
May 12, 2023
Merged

Updating the PA zip creation logic for docker build#357
khushbr merged 2 commits intoopensearch-project:mainfrom
khushbr:clone-pa-fix

Conversation

@khushbr
Copy link
Copy Markdown
Collaborator

@khushbr khushbr commented May 12, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Addressing the build failure due to gradle version upgrade. From https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/4833884278/jobs/8815180043:

* What went wrong:
A problem was found with the configuration of task ':clonePaGitRepo' (type 'GitClone').
  - Type 'org.ajoberstar.gradle.git.tasks.GitClone' property 'authentication' is missing an input or output annotation.
    
    Reason: A property without annotation isn't considered during up-to-date checking.

Describe the solution you are proposing
Removing the redundant git clone and replacing with pulling Snapshots from Maven Snapshot repo(https://aws.oss.sonatype.org/content/repositories/snapshots). Refer: https://opensearch.org/blog/opensearch-plugin-zips-now-in-maven-repo/

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

khushbr added 2 commits May 10, 2023 22:22
…udant git clone with pulling artifacts from ci.opensearch.org

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
@codecov
Copy link
Copy Markdown

codecov bot commented May 12, 2023

Codecov Report

Merging #357 (290b321) into main (426c78b) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 290b321 differs from pull request most recent head 13dc8ec. Consider uploading reports for the commit 13dc8ec to get more accurate results

@@             Coverage Diff              @@
##               main     #357      +/-   ##
============================================
- Coverage     72.79%   72.76%   -0.04%     
+ Complexity     3047     3043       -4     
============================================
  Files           381      381              
  Lines         19013    19013              
  Branches       1472     1472              
============================================
- Hits          13841    13834       -7     
- Misses         4579     4582       +3     
- Partials        593      597       +4     
Impacted Files Coverage Δ
...ceanalyzer/metrics/PerformanceAnalyzerMetrics.java 37.97% <ø> (ø)
...er/rca/framework/api/summaries/HotNodeSummary.java 58.92% <ø> (ø)
...anceanalyzer/rca/store/metric/AggregateMetric.java 82.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants