Skip to content

Bump commons-io version from 2.3 to 2.7 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sruti1312 merged 2 commits into from
Sep 23, 2021
Merged

Bump commons-io version from 2.3 to 2.7 #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43c0915
Remove emitting the entry key with the METRICS_WRITE_ERROR metric (#71)
sruti1312 Sep 21, 2021
49fb7a4
Update commons-io version
sruti1312 Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ dependencies {
compile group: 'org.apache.logging.log4j', name: 'log4j-api', version: '2.13.0'
compile group: 'org.apache.logging.log4j', name: 'log4j-core', version: '2.13.0'
compile group: 'org.apache.commons', name: 'commons-lang3', version: '3.9'
compile group: 'commons-io', name: 'commons-io', version: '2.3'
compile group: 'commons-io', name: 'commons-io', version: '2.7'
implementation 'io.grpc:grpc-netty-shaded:1.28.0'
implementation 'io.grpc:grpc-protobuf:1.28.0'
implementation 'io.grpc:grpc-stub:1.28.0'
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/opensearch/performanceanalyzer/metrics/PerformanceAnalyzerMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public static void addMetricEntry(StringBuilder value, String metricKey, long me
private static void emitMetric(BlockingQueue<Event> q, Event entry) {
if (!q.offer(entry)) {
PerformanceAnalyzerApp.WRITER_METRICS_AGGREGATOR.updateStat(
WriterMetrics.METRICS_WRITE_ERROR, entry.key, 1);
WriterMetrics.METRICS_WRITE_ERROR, "", 1);
LOG.debug("Could not enter metric {}", entry);
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/org/opensearch/performanceanalyzer/reader/MetricsEmitterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,8 @@ public void testThreadNameCategorization() {
"search",
MetricsEmitter.categorizeThreadName("opensearch[I9AByra][search]", dimensions));
assertEquals(
"write", MetricsEmitter.categorizeThreadName("opensearch[I9AByra][bulk]", dimensions));
"write",
MetricsEmitter.categorizeThreadName("opensearch[I9AByra][bulk]", dimensions));
assertEquals("other", MetricsEmitter.categorizeThreadName("Top thread random", dimensions));
}

Expand Down