Remove jackson-databind and jackson-annotations now coming from core#349
Merged
Remove jackson-databind and jackson-annotations now coming from core#349
Conversation
Signed-off-by: David Zane <davizane@amazon.com>
Member
Author
|
WhiteSource Security Check failing due to bad Netty version. I will fix that in a separate PR |
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
=========================================
Coverage 70.82% 70.82%
Complexity 372 372
=========================================
Files 44 44
Lines 2581 2581
Branches 174 174
=========================================
Hits 1828 1828
Misses 641 641
Partials 112 112 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kiranprakash154
approved these changes
Dec 28, 2022
kkhatua
approved these changes
Dec 28, 2022
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-349-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b8d3a4c996788c832355d17a074c14b8e733e52c
# Push it to GitHub
git push --set-upstream origin backport/backport-349-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
5 tasks
dzane17
added a commit
that referenced
this pull request
Dec 29, 2022
dzane17
added a commit
that referenced
this pull request
Jan 5, 2023
…349) Signed-off-by: David Zane <davizane@amazon.com>
ryanbogan
added a commit
to ryanbogan/performance-analyzer
that referenced
this pull request
Jan 10, 2023
…om core (opensearch-project#349)' Signed-off-by: Ryan Bogan <rbogan@amazon.com>
kiranprakash154
pushed a commit
to kiranprakash154/performance-analyzer
that referenced
this pull request
Jan 11, 2023
…om core (opensearch-project#349)' Signed-off-by: Ryan Bogan <rbogan@amazon.com>
5 tasks
kiranprakash154
added a commit
that referenced
this pull request
Jan 11, 2023
…ore' (#369) * Revert 'Remove jackson-databind and jackson-annotations now coming from core (#349)' Signed-off-by: Ryan Bogan <rbogan@amazon.com> * update licenses Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update licenses Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com> Co-authored-by: Ryan Bogan <rbogan@amazon.com>
This was referenced Jan 11, 2023
kaushalmahi12
pushed a commit
to kaushalmahi12/performance-analyzer
that referenced
this pull request
Jan 18, 2023
…pensearch-project#349) Signed-off-by: David Zane <davizane@amazon.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/performance-analyzer
that referenced
this pull request
Jan 18, 2023
…ore' (opensearch-project#369) * Revert 'Remove jackson-databind and jackson-annotations now coming from core (opensearch-project#349)' Signed-off-by: Ryan Bogan <rbogan@amazon.com> * update licenses Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update licenses Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com> Co-authored-by: Ryan Bogan <rbogan@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Zane davizane@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Fixes #344
Describe the solution you are proposing
Remove direct jackson-databind and jackson-annotations direct dependency in PA.
Also pick Jackson versions from OpenSearch props file https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/version.properties
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.