Skip to content

Handling purging of lingering files before scheduleExecutor start.#37

Merged
khushbr merged 3 commits intoopensearch-project:mainfrom
khushbr:feature/purge-fix
Jul 14, 2021
Merged

Handling purging of lingering files before scheduleExecutor start.#37
khushbr merged 3 commits intoopensearch-project:mainfrom
khushbr:feature/purge-fix

Conversation

@khushbr
Copy link
Copy Markdown
Collaborator

@khushbr khushbr commented Jul 14, 2021

Is your feature request related to a problem? Please provide an existing Issue # , or describe.

  1. Addresses Joydeep's comment on PR-36. Moved deleteAllFiles() to inside scheduleExecutor(), this ensures that deleteAllFiles() is invoked once and before beginning of event log file generation.
  2. Minor change around fixing the official documentation to resolve Link Checker errors.

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@khushbr khushbr requested a review from sruti1312 July 14, 2021 20:12
@sruti1312
Copy link
Copy Markdown
Contributor

We need to fix these failing tests:
Tests with failures:

  • org.opensearch.performanceanalyzer.reader_writer_shared.EventLogFileHandlerTests.testNoFileWithNoMetrics
  • org.opensearch.performanceanalyzer.reader_writer_shared.EventLogFileHandlerTests.testFileWithMetrics

@khushbr khushbr merged commit 9c79039 into opensearch-project:main Jul 14, 2021
@khushbr khushbr deleted the feature/purge-fix branch July 14, 2021 23:08
sruti1312 pushed a commit that referenced this pull request Aug 25, 2021
Handling purging of lingering files before scheduleExecutor start.
sruti1312 added a commit that referenced this pull request Aug 25, 2021
* Create writer file if metrics are available (#31)

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Add tests to check for writer file only if metrics are present (#35)

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Merge pull request #36 from opensearch-project/khushbr-writer-purge-fix

Fixing Event Log file cleanup issue

* Moving deleteAllFiles() to inside scheduleExecutor()

* Fixing the Link Checker errors, updating the official documentation

* nit: Fixing spotlessJava indentation issue

* Merge pull request #37 from khushbr/feature/purge-fix

Handling purging of lingering files before scheduleExecutor start.

* Fix failing file handler test (#38)

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Remove dependency on main branch when running spotless. (#47)

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Updates to gradle build file (#48)

* Updates to gradle build file

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Add ability to specify RCA branch

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Fix build when opensearch_version flag is provided. (#52)

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Update the version to 1.0.1

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com>
Co-authored-by: Khushboo Rajput <khushbr@amazon.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants