Add field type to query shape and extensive unit tests#140
Merged
jainankitk merged 5 commits intoopensearch-project:mainfrom Oct 10, 2024
Merged
Add field type to query shape and extensive unit tests#140jainankitk merged 5 commits intoopensearch-project:mainfrom
jainankitk merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
52dab34 to
5239f68
Compare
dda1aa4 to
f05c5d2
Compare
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
f05c5d2 to
eb2877d
Compare
jainankitk
reviewed
Oct 10, 2024
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
jainankitk
reviewed
Oct 10, 2024
Collaborator
jainankitk
left a comment
There was a problem hiding this comment.
Looks much better now. Minor comments to improve the readability
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
7026815 to
d67e5fc
Compare
jainankitk
approved these changes
Oct 10, 2024
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
* Add query type to shape and extensive unit tests Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Log query shape if trace log enabled Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Refactor code, handle multifield with test, remove properties cache Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Use only first index and optimization to get properties once per query Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Further refactoring Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> --------- Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> (cherry picked from commit dcf52c2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.17
# Create a new branch
git switch --create backport/backport-140-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dcf52c28a6bd7ed169c71fd8c006e56db7b73f13
# Push it to GitHub
git push --set-upstream origin backport/backport-140-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.17Then, create a pull request where the |
deshsidd
pushed a commit
that referenced
this pull request
Oct 10, 2024
* Add query type to shape and extensive unit tests * Log query shape if trace log enabled * Refactor code, handle multifield with test, remove properties cache * Use only first index and optimization to get properties once per query * Further refactoring --------- (cherry picked from commit dcf52c2) Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Member
|
@deshsidd don't backport this to 2.17, this is for open source 2.18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add field type to query shape and integrate with the setting changes for
field_nameandfield_type: #135Example
Field Mapping:
Query:
Query Shape:
Local Sanity Testing Logs
field_typeandfield_nameenabled/disabledresolves: #69