Merged
Conversation
msfroh
force-pushed
the
improve-coverage
branch
from
2bdf023 to
bbdb2fe
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #100 +/- ##
============================================
+ Coverage 76.53% 80.93% +4.40%
- Complexity 195 215 +20
============================================
Files 29 29
Lines 882 881 -1
Branches 119 120 +1
============================================
+ Hits 675 713 +38
+ Misses 146 106 -40
- Partials 61 62 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Added tests for Document, KendraClientSettings, and SimpleAwsErrorHandler. Also deleted some dead code from TransformerType and KendraIntelligentRankingException. Works toward opensearch-project#31 Signed-off-by: Michael Froh <froh@amazon.com>
msfroh
force-pushed
the
improve-coverage
branch
from
bbdb2fe to
4bd2298
Compare
mingshl
reviewed
Feb 8, 2023
| */ | ||
| public Document() { | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
if no return type, should it be void?
Collaborator
Author
There was a problem hiding this comment.
It's a constructor.
It doesn't return anything so much as it initializes the object (in this case, it initializes all fields to null).
mingshl
approved these changes
Feb 8, 2023
mingshl
pushed a commit
that referenced
this pull request
Feb 24, 2023
Added tests for Document, KendraClientSettings, and SimpleAwsErrorHandler. Also deleted some dead code from TransformerType and KendraIntelligentRankingException. Works toward #31 Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit 82e59f1) Co-authored-by: msfroh <froh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for Document, KendraClientSettings, and SimpleAwsErrorHandler.
Also deleted some dead code from TransformerType and
KendraIntelligentRankingException.
Works toward
#31
Signed-off-by: Michael Froh froh@amazon.com
Description
Added unit tests for Document, KendraClientSettings, and SimpleAwsErrorHandler.
Issues Resolved
#31
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.